DSA Info page#1128
Conversation
|
Deployment previews on netlify for branch
|
dati18
left a comment
dati18
left a comment
There was a problem hiding this comment.
I added a few comments but the e2e test is still "red" so I will move this back to TODO
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
Looking good so far. Found a few issues and differences from the Figma design.
rosalieper
left a comment
rosalieper
left a comment
There was a problem hiding this comment.
I am happy with this change being merged once the linting is fixed
This change came up with #1128 and I put it in its own PR because #1130 also needs this This fix addresses several things: 1. scroll to the top of the page after following an internal page link 2. making on-page anchor-links (#) work specified with vue router-link https://phabricator.wikimedia.org/T408254 https://phabricator.wikimedia.org/T420575
| </script> | ||
|
|
||
| <style scoped></style> | ||
| <style> |
There was a problem hiding this comment.
How come scoped is removed here? As I understand it, this CSS will be applied to all pages.
Having global CSS in single-file components has made it hard to debug styling issues in the past.
There was a problem hiding this comment.
Ah good point, I didn't realize it was global. What I wanted was to not duplicate the css for both the child components, but I now found out about :deep https://vuejs.org/api/sfc-css-features.html#deep-selectors
4 participants
https://phabricator.wikimedia.org/T408254
Bug: T408254