tests: prevent output in phpunit tests#1158
Open
outdooracorn wants to merge 2 commits into
Open
Conversation
* Modify `ElasticSearchIndexDeleteTest` so it doesn't print output. * `beStrictAboutOutputDuringTests` marks tests as "risky" if there is output printed. * `failOnRisky` makes the test suite fail if any tests are marked as "risky". Bug: T428716
outdooracorn
force-pushed
the
prevent-output-in-phpunit-tests
branch
from
107b920 to
ec2cbd2
Compare
Contributor
|
+1 to fix the test by calling a bit unsure about removing the output from the integration test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElasticSearchIndexDeleteTestso it doesn't print output.beStrictAboutOutputDuringTestsmarks tests as "risky" if there is output printed.failOnRiskymakes the test suite fail if any tests are marked as "risky".Bug: T428716