Update PublicWikiController parameter validation and add unit tests#1156
Merged
Conversation
outdooracorn
commented
Jun 10, 2026
Member
Author
There was a problem hiding this comment.
WIP until we have informed the suite team and they have changed https://github.com/wmde/wikibase-metadata/blob/748652566556d1255e8dc79c21b64bd58c2b6bb9/backend/fetch_data/cloud_api_data/get_cloud_api_data.py#L7
Contributor
I actually think we can change this endpoint without trying to coordinate given we provide no formal stability offers for this endpoint |
tarrow
reviewed
Jun 10, 2026
tarrow
previously approved these changes
Jun 11, 2026
* Validate `page` and `per_page` params as integers rather than numbers * Add `page` and `per_page` minimum limit of 1 * Add `per_page` maximum limit of 100 Bug: T421877
tarrow
force-pushed
the
improve-PublicWikiController-validation
branch
from
8349d22 to
0b72027
Compare
tarrow
reviewed
Jun 11, 2026
tarrow
approved these changes
Jun 11, 2026
tarrow
left a comment
tarrow
left a comment
Contributor
There was a problem hiding this comment.
boldly approving my own lint change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pageandper_pageparams as integers rather than numberspageandper_pageminimum limit of 1per_pagemaximum limit of 100Bug: T428711