Fix blank admin icon picker + sync wbcom-settings shell to 1.0.2 - #6
Merged
Conversation
…1.0.2 - Icon picker: enqueue Font Awesome on the settings screen. The 'Choose icon' grid rendered blank because no icon stylesheet loaded in wp-admin. Loads fontawesome5.min.css - the Font Awesome 5 Free build the frontend already uses, with its webfonts bundled - so the picker shows exactly the icons the loader renders on the storefront. (The sibling font-awesome.min.css is a Pro build with no shipped webfonts and cannot render; it is deliberately not used.) - Shell: sync the bundled wbcom-settings copy to 1.0.2 - the wp-header-end marker so the 'Settings saved' notice sits at the top of the screen rather than inside a tab section, and the card styling for that notice. Removes the per-screen #setting-error-settings_updated override that floated the notice as bare text and beat the shell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes verified on WP 7.1 / WC 11: