Docs: fix fabricated security claims, phantom hooks, stale requirements - #19
Merged
Merged
Conversation
Accuracy (P0) - remove security claims the source contradicts: - Remove all nonce claims/examples from developer-guide.md and faq-guide.md (wp_verify_nonce, X-WP-Nonce header, ajax_nonce config field, "nonce verification on all AJAX requests"). The load-more endpoint is a read-only GET of a public archive and the per-visitor nonce was dropped in 1.3.0 for page-cache compatibility; explain why instead. - Remove the "rate limiting to prevent abuse" claim (removed in 1.3.2). Phantom / mislabeled: - Remove phantom filters infinite_loader_loading_types and infinite_loader_load_more_button_html (never existed). - Relabel the 5 "Frontend Actions" as jQuery events, not PHP do_action - the plugin fires no frontend do_action. - Correct the AJAX handler: it is Infinite_Loader_For_Woocommerce_Admin::handle_infinite_loader_ajax on template_redirect (Admin class), renders products-only, no nonce. - Fix stale requirements (WP 6.5 / PHP 8.0) in user-guide.md and faq-guide.md. - Fix phantom version 1.2.4 references (features shipped in 1.3.0). - README.txt "Tested up to" 7.0 -> 6.9 (7.0 does not exist). Coverage: - Document 8 real but undocumented filters: should_load_assets, js_function, next_page_selector, prev_page_selector, previous_btn_hover_css, for_woocommerce_load_previous_button_style, wbcom_infinite_loader_image, settings_nav_groups. - Add an EDD licensing/activation section (option keys, activate/deactivate). - README.txt (the only doc shipped to customers): add a settings overview and a developer-hooks pointer. Also correct CAPABILITIES.md: real EDD license option keys, drop the removed rate-limit transient, and note the uninstall.php license-key mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation accuracy + coverage pass for v1.3.2. Every claim was verified against source with grep before editing. Doc files only - no code or dist/ changes.
P0 Accuracy - fabricated security removed
wp_verify_nonce,X-WP-Nonceheader,ajax_nonceconfig field, and "nonce verification on all AJAX requests". Source has zerowp_verify_nonce/check_ajax_refereron the load-more path; the JS explicitly notes "No nonce here on purpose" (read-only cached GET). The per-visitor nonce was dropped in 1.3.0 for page-cache compatibility - docs now explain why instead of claiming verification.check_rate_limit/infinite_loader_rate_limitwere removed in 1.3.2; no remnants in source.Phantom / mislabeled
infinite_loader_loading_typesandinfinite_loader_load_more_button_html(do not exist).$(document).trigger()events - the plugin fires no frontenddo_action.Infinite_Loader_For_Woocommerce_Admin::handle_infinite_loader_ajaxontemplate_redirect(Admin class, not Public), renders products-only, no nonce.1.2.4references (changelog jumps 1.2.2 -> 1.3.0; those features shipped in 1.3.0).Tested up to: 7.0->6.9(WP 7.0 does not exist).Coverage
should_load_assets,js_function,next_page_selector,prev_page_selector,previous_btn_hover_css,for_woocommerce_load_previous_button_style,wbcom_infinite_loader_image,settings_nav_groups..distignored): added a settings overview and a developer-hooks pointer.Extra finding (also fixed in docs)
edd_wbcom_infinite_loader_license_key/_status), removed the stale rate-limit transient, version 1.3.1 -> 1.3.2.Code bug found (NOT fixed here - out of doc scope)
uninstall.phpdeletesinfinite_loader_license_key/_statusand transientinfinite_loader_license_data, but the license code actually writesedd_wbcom_infinite_loader_license_key/_statusand transientedd_wbcom_infinite_loader_license_key_data. License options are never cleaned up on uninstall. Worth a follow-up fix.Version was NOT bumped.