Repository navigation
fix(web): isolate CEF cache per renderer process - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give each web renderer process its own CEF root cache directory.
When duplicate renderers are enabled, multiple
waywallen-weweb-rendererprocesses for the same Wallpaper Engine web wallpaper currently derive the same CEF cache path from the Workshop ID. The first renderer starts successfully, while the second can fail duringCefInitializebecause Chromium treats the shared profile as an existing browser session.This appends the renderer process ID to the cache path so each renderer gets an independent CEF root cache.
Reproduction of the bug
Opening in existing browser session.weweb: CefInitialize failedBrowserHost::Init failedTested
Built using the project's official
scripts/build_waywallen_plugin.shpackaging flow and tested with the Waywallen Flatpak.With this change, multiple web renderer processes for the same wallpaper start successfully and coexist without the CEF initialization failure.