Repository navigation
plugin: label the scene and web wallpaper types - #152
Merged
Merged
Conversation
The scene and web renderers declared their types but no display labels, so waywallen's status page showed the raw ids "scene" and "web" next to the translated "Image" and "Video". Point them at the "Scene" and "Web" msgids the plugin catalog already translates. Daemons older than waywallen 0.4.0 ignore the key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waywallen's own image and video renderers already declare type_labels since waywallen#266, so the status page shows "Image" and "Video" in the user's language, while scene and web still show their raw ids. This adds the same key to both renderer manifests, pointing at the "Scene" and "Web" msgids that i18n/ru.po and i18n/zh-CN.po already translate for the Workshop type filter, so no new strings are needed.
I checked it with a waywallen build from main and the installed 0.3.0 plugin with the two lines added: in Russian the line goes from "scene, web" to "Сцена, Веб". Daemons older than 0.4.0 don't know the key and simply ignore it, since RendererDef doesn't deny unknown fields.