feat: reduce jitter from bar resize with non-monospace fonts - #339
Open
waltmck wants to merge 3 commits into
Open
feat: reduce jitter from bar resize with non-monospace fonts#339waltmck wants to merge 3 commits into
waltmck wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, bar buttons would often move around from left to right as displayed numbers changed. This caused other buttons and even open dropdowns to move around as well.
This PR mitigates that with a few layout heuristics:
I also added non-zero-padded hours and days
%-dand%-Hand made these the new defaults, and disableddropdown-freeze-labelby default since it is no longer as big a problem.