feat(battery): support profile-based charge limit UI messages - #332
Open
JoJoStax wants to merge 1 commit into
Open
feat(battery): support profile-based charge limit UI messages#332JoJoStax wants to merge 1 commit into
JoJoStax wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The battery dropdown currently assumes charge limits are strictly percentage-based numeric thresholds. However, certain laptops (like Lenovo IdeaPads and other brands) use sysfs profile-based charge limits (e.g.,
Long_LifevsStandard), which UPower abstracts. When these profile-based limits are active, the backend returns a threshold of0, causing the UI to confusingly display "Limit to 0%".Backend Context: This PR depends on wayle-services#38, which implements the fallback mechanism to detect and handle profile-based limits.
Solution
Updated
BatterySectionto handle0percentage limits as profile-based optimized limits rather than literal zero percent:dropdown-battery-charge-limit-optimizedanddropdown-battery-charge-limit-optimized-subtitlewayle-shell/src/shell/bar/dropdowns/battery/battery_section/mod.rsto detect whenmodel.charge_end_threshold == 080) continue to display normallyTest Plan
charge_types(profile-based limits)0