feat: suport systemd type=Notify ordering - #323
Open
waltmck wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Wayle signal
NOTIFY_SOCKETafter all service constructors finish. In particular, this (combined with tweaking the.servicefile to useType=notifyand enforce ordering) preventsxdg-autostart-ed apps from starting too soon and trying to send a notification before Wayle finishes setting up its notification service. Previously, this race could lead to two undesirable outcomesorg.freedesktop.Notificationseven whenorg.gtk.Notificationsis availablesd_notify signaling only happens when Wayle is run with
wayle shell, not withwayle panel start(this is to prevent unexpected behavior on misconfigured setups that useexec-start=wayle panel shellor similar in a compositor service withType=notifybut withoutNotifyAccess=main; in this case, Wayle might incorrectly signal readiness for the compositor service it runs in rather than for itself).Added a new dependency
sd-notify, and also needed to fix(?) a build script bug that led to fragile link ordering guarantees.