0.11.1 — stability pass (adversarial review fixes) - #10
Merged
Conversation
Both API clients could loop forever when a list response had a non-numeric `pages` total, and busy-loop with no delay when a 429 `Retry-After` was non-numeric (e.g. an HTTP-date). Coerce + validate, falling back to a sane delay / terminating the page loop.
- Pass tool flags as --name=value and positionals after --, so an argument value starting with - can't be reinterpreted as a CLI flag. - Report a signal-killed tool subprocess as an error (was silent success). - Add a timeout + output-size cap to tool execution (no server hang/OOM). - Forward the active --profile to tool subprocesses (was using default). - Accept JSON numbers for integer args; drop the inert `yes` input. - Exclude auth:*/docs:auth (local creds, browser/port side-effects); flag workflow:run destructive. Correct the guide's hint description.
- Reports reject --output csv/table clearly (nested data) instead of emitting
nothing; docs reframed to JSON.
- readText('@missing') throws a clear CliError, not a raw ENOENT.
- Keychain write failures (e.g. in a container) give the friendly
'keychain unavailable' guidance instead of a raw PermissionDenied.
- Homebrew formula depends on jq and points node-jq at it via $JQ_PATH, so
--jq works (the bundled binary can't download in the brew sandbox).
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a four-agent contrarian review of 0.11.0. All real bugs that sat at 100% coverage.
CRITICAL
paginateinfinite-loop on a non-numericpages(both clients) — self-DoS.--jqcrashed (node-jq's binary isn't downloadable in the brew sandbox) — formula nowdepends_on "jq"+$JQ_PATH, with a--jqsmoke intest do.HIGH (MCP)
--name=value, positionals after--).mcp serveforwards--profile(was wrong-account).auth:*/docs:authexcluded;workflow:rundestructive.Retry-After.MEDIUM
--output csv/tableclearly (were silently empty); docs reframed to JSON.readText('@missing')→ clear error; keychain write failures → friendly guidance.730 tests, 100% coverage; lint clean. Post-merge: regen the Homebrew formula and push to the tap.