feat(voice): add negotiated codec to call records#35
Merged
Conversation
VoiceCallRecord gains an optional codec field (opus / pcmu / pcma, matching the daemon's CallCodec wire strings) so the platform can show a call's audio quality the way the desktop client now does. Daemon-owned data like transfer_target: sent on sync when present, echoed back on read, absent for never-answered calls and rows from older daemons. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VoiceCallRecordgains an optionalcodecfield — the audio codec the call negotiated (opus/pcmu/pcma), as a new wire-stableVoiceCallCodecenum matching the daemon'sCallCodecstrings.transferTarget: serialized on sync when present, echoed back on read, omitted (nevernull) for never-answered calls and rows synced by older daemons.Consumers render it as a quality tier — "HD" for Opus, "Standard" for G.711 — matching the desktop client's call-details page. The platform-side ingest/storage/UI lands in
wavekat-platformalongside this.Test plan
codec_pins_its_wire_strings— pins the exact wire strings the platform's Zod schema will validate against.record_round_trips_codec— parse → re-serialize both ways, plus the legacy-row (absent field) case.codecis omitted whenNone.cargo test: 73 passed.🤖 Generated with Claude Code