feat(voice): add per-channel default-mute to share#31
Merged
Conversation
A shared recording's player can start with one side muted by default. Add default_mute_local / default_mute_remote (Option<bool>) to ShareRecordingRequest, ShareRecordingResponse and ShareStateResponse, mirroring the existing show_audio / allow_download controls. Each is omitted when unset (platform defaults to audible) and only meaningful while show_audio is true. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011v4mQUm4uU4kwf6jGfNptW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a per-channel default mute to the recording-share API: which side of a call starts muted in the shared player.
A call has two channels —
local(the owner's mic, "your side") andremote(the other party, "their side"). The owner can mark a side as muted-by-default; the viewer can still un-mute it, and the audio file is unchanged. This is only the player's starting state.Changes
default_mute_local/default_mute_remote(Option<bool>) added toShareRecordingRequest,ShareRecordingResponse,ShareStateResponseinsrc/voice.rs, alongside the existingshow_audio/allow_downloadcontrols.defaultMuteLocal/defaultMuteRemote); omitted when unset → platform applies its default (audible). Only meaningful whileshow_audiois true.Consumed by
wavekat-voice(daemon + share sheet) and the platform viewer/player.🤖 Generated with Claude Code