feat(voice): add allow_download to share request/state#29
Merged
Conversation
Mirror the platform's new fourth share-visibility axis: whether a viewer may download the recording's WAV, distinct from whether they may hear it. Adds `allow_download: Option<bool>` to ShareRecordingRequest, ShareRecordingResponse, and ShareStateResponse — omitted when unset, so the platform applies its privacy-forward default (off). On the response side the field is the *effective* permission (`show_audio && allow_download`), so it's never true when the audio is hidden. A platform predating the control omits it; assume off. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011v4mQUm4uU4kwf6jGfNptW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the fourth per-share visibility axis to the share types: whether a
viewer may download the recording's WAV, distinct from whether they
may hear it.
ShareRecordingRequest.allow_download: Option<bool>— omitted whenunset, so the platform applies its privacy-forward default (off). Only
meaningful while
show_audiois true; the platform forces it offotherwise.
ShareRecordingResponse.allow_download/ShareStateResponse.allow_download— the effective permission (
show_audio && allow_download), so nevertrue when the audio is hidden. Absent on a platform predating the
control (assume off).
All additive and
skip_serializing_if = "Option::is_none", matching theexisting show_audio / show_transcript / party_masking controls.
Tests: extended the share serialize/parse cases for the new field (off
the wire when unset, camelCase
allowDownloadwhen set, parsed back onthe state read).
cargo test/clippy/fmt --checkclean.🤖 Generated with Claude Code