fix: re-export PartyMasking from the crate root#27
Merged
Conversation
0.0.13 (#25) added `PartyMasking` to the `voice` module and used it on `ShareRecordingRequest` / `ShareStateResponse` / `ShareRecordingResponse`, but never added it to the crate-root `pub use voice::{…}`. Since `voice` is a private module, the type is unreachable from a consumer: `wavekat-voice` can name `ShareRecordingRequest` but not the `PartyMasking` value its `party_masking` field needs, so it can't set the per-share visibility controls at all. Add `PartyMasking` to the root re-export (every other share type is already there) and a compile-time reachability test over all four share-control types so a future omission fails here, not in a downstream crate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011v4mQUm4uU4kwf6jGfNptW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PartyMaskingwas added to thevoicemodule in #25 (0.0.13) and is used onShareRecordingRequest,ShareStateResponse, andShareRecordingResponse— but it was never added to the crate-rootpub use voice::{…}. Sincevoiceis a private module, the type is unreachable from a consumer.The practical effect:
wavekat-voicecan nameShareRecordingRequestbut not thePartyMaskingvalue itsparty_maskingfield needs, so it can't set the per-share visibility controls at all. Every other share-control type (ShareVisibility, the request/response structs) is already re-exported;PartyMaskingwas simply missed.Change
PartyMaskingto the root re-export, alongside the share types it travels with.PartyMasking,ShareVisibility,ShareRecordingRequest,ShareRecordingResponse) via thecrate::root path, so a future re-export omission fails here rather than in a downstream crate.Additive only — no API change, no behavior change. On merge, release-plz cuts 0.0.14, which
wavekat-voicethen pins to (it's currently consuming this fix via a temporary local[patch.crates-io]while wiring up the controls).Tests
cargo testgreen; the newshare_visibility_types_are_reachable_from_the_crate_roottest passes and would fail to compile if any of the four types lost its root re-export.cargo fmt --all -- --checkclean.🤖 Generated with Claude Code