[nitro 6/6] Cleanup, docs, changelog, migration guide - #4707
Draft
cprecioso wants to merge 2 commits into
Draft
Conversation
- delete waspc/data/Generator/libs/vite-ssr (unshipped since part 1) - single-process CLI pass: JobType WebApp|Server -> App, '[ App ]' output prefix, Doctor drops the 3001 check, build-start env flags re-documented as build-time vs run-time, deploy's dead --skip-client/ --custom-server-url flags marked deprecated-and-ignored - example lockfiles regenerated (rollup/esbuild trees gone) - web/docs sweep for the single-container model: websockets rewritten for the crossws API, deployment narrative + provider guides (render/railway/heroku/flyio single-container; netlify/cloudflare honest stubs; vps/coolify/caprover rewritten), env-vars/middleware/ server-config/apis/prerendering/cli pages, port/URL sweep, markdown snapshots regenerated - migration guide: 9 steps (WebSocket before/after + translation table, setupFn server removal, env simplification, single-container deploys, Dockerfile stage renames, SPA fallthrough, JSON errors) - ChangeLog.md: Nitro stack entries under the unreleased 0.26.0 section (no version bump: 0.26.0 is unreleased and already carries this cycle's breaking-change bump) Known gap (documented in docs/changelog, needs a deploy-adapter follow-up): wasp deploy cannot pass client env vars to the provider-side image build.
Deploying wasp-docs-on-main with
|
| Latest commit: |
1719b9d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8902f2a1.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://cprecioso-nitro-06-cleanup.wasp-docs-on-main.pages.dev |
cprecioso
had a problem deploying
to
fly-deploy-test
August 12, 2026 22:10 — with
GitHub Actions
Failure
cprecioso
had a problem deploying
to
railway-deploy-test
August 12, 2026 22:10 — with
GitHub Actions
Failure
@wasp.sh/spec
@wasp.sh/wasp-cli
@wasp.sh/wasp-cli-darwin-arm64-unknown
@wasp.sh/wasp-cli-darwin-x64-unknown
@wasp.sh/wasp-cli-linux-arm64-glibc
@wasp.sh/wasp-cli-linux-x64-glibc
@wasp.sh/wasp-cli-linux-x64-musl
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 6 of 6 — the Nitro migration stack closer (stacked on #4705). Cleanup, docs, changelog, and the migration guide for the whole stack.
waspc/data/Generator/libs/vite-ssr/deleted (unshipped since part 1; build tooling auto-discovers, so no other wiring changes were needed).JobTypeloses theServerconstructor and dev output is prefixed[ App ];wasp doctordrops the 3001 check;wasp build start's env flags are re-documented as build-time vs run-time; the deploy CLI's now-dead--skip-client/--custom-server-urlflags are kept but marked deprecated-and-ignored (commander hard-errors on unknown flags, so removal would break users' CI).web/docsonly): the WebSockets page fully rewritten for the crossws API; the deployment narrative and every provider guide rewritten for the single-container model (netlify/cloudflare become honest "can't host this" stubs); env-vars/middleware/server-config/apis/prerendering/CLI pages updated; ports/URLs swept across social-auth and integration guides; markdown snapshots regenerated. Local Docusaurus build passes withonBrokenLinks: "throw"(CI wouldn't have caught these — the web-check skipsweb/docs).setupFn'sserver, env simplification, single-container deployment +WASP_CLIENT_ENV+/_wasp/health, Dockerfile stage renames, SPA fallthrough, JSON error responses.Known product gap surfaced here, needs a decision in the deploy-adapter follow-up:
wasp deploycan no longer pass client env vars (REACT_APP_*) — part 5 removed the host-side client build, and neither Fly nor Railway forwards a--build-argto the provider-side image build. Apps with client env vars must build the image themselves for now; docs/changelog/migration guide say this honestly.flyctl deploy --build-argexists, so a fix looks feasible.Verified: 657/657 unit tests; goldens comparison-verified with zero churn (Phase 6 touches no templates; the regenerated example lockfile is excluded from snapshots by the harness); deploy package typechecks + 63/63 vitest; Docusaurus builds clean; smoke on a fresh app — single
[ App ]process on 3000, nothing on 3001,/_wasp/healthgreen,wasp cleanclears everything; all 7 examples compile.Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.