feat(wasix): support TCB OOB and exceptfds - #6861
Open
kilyanni wants to merge 2 commits into
Open
Conversation
kilyanni
force-pushed
the
oob-readiness-refactor
branch
from
August 6, 2026 12:47
a735880 to
6066d4a
Compare
kilyanni
marked this pull request as ready for review
August 6, 2026 12:47
kilyanni
force-pushed
the
oob-readiness-refactor
branch
from
August 7, 2026 11:33
6066d4a to
7915146
Compare
Contributor
Author
|
Previously only handled the read half, added the write half as well now |
kilyanni
commented
Aug 7, 2026
Comment on lines
+1632
to
+1639
| InodeSocketKind::TcpStream { socket, .. } => { | ||
| let received = if self.oob { | ||
| socket.try_recv_oob(self.data, peek) | ||
| } else { | ||
| socket.try_recv(self.data, peek) | ||
| }; | ||
| received.and_then(|amt| socket.addr_peer().map(|addr| (amt, addr))) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
For all other matches here, I added only an if oob arm, but this fn didn't have a TCP arm at all, so this changes non-OOB behavior as well.
I think that it missing was a latent bug in our recvfrom, so added both OOB and non-OOB paths
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support TCB out-of-band data and
exceptfdswasix-libcsupport to followRe: wasix-org/wasix-libc#127