chore: bump napi: drain the platform's fallback foreground-task queue - #6845
Open
Arshia001 wants to merge 1 commit into
Open
chore: bump napi: drain the platform's fallback foreground-task queue#6845Arshia001 wants to merge 1 commit into
Arshia001 wants to merge 1 commit into
Conversation
1 task
Picks up wasmerio/napi#<pending> (branch fix/foreground-task-queue-drain on top of guest-heap-mandatory-alloc), which fixes V8-internal FinalizationRegistry cleanup callbacks never firing in the napi-v8 embedding: the cleanup task V8 posts after GC is silently dropped whenever the guest hasn't bound its own foreground-task hook (edgejs never does -- it drives everything through unofficial_napi_process_microtasks), because nothing pumped the fallback platform runner those tasks fell back to. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Arshia001
force-pushed
the
fix/foreground-task-queue-drain
branch
from
August 4, 2026 13:56
ec91df3 to
aa82623
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the lib/napi git submodule to pick up wasmerio/napi#50, addressing a correctness issue in the napi-v8 embedding where V8-internal deferred foreground tasks (notably FinalizationRegistry cleanup callbacks) could be silently dropped when the guest never binds a foreground-task hook and only drives execution via unofficial_napi_process_microtasks.
Changes:
- Updates the
lib/napisubmodule pointer to include the upstream fix that explicitly drains the fallback platform foreground-task queue. - Ensures V8鈥檚 post-GC FinalizationRegistry cleanup work has an opportunity to run even without a guest-provided foreground-task enqueue hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up wasmerio/napi#50 (branch `fix/foreground-task-queue-drain` on top
of `guest-heap-mandatory-alloc`), which fixes V8-internal
FinalizationRegistry cleanup callbacks never firing in the napi-v8
embedding: the cleanup task V8 posts after GC was silently dropped whenever
the guest hadn't bound its own foreground-task hook (edgejs never does --
it drives everything through `unofficial_napi_process_microtasks`),
because nothing pumped the fallback platform runner those tasks fell back
to.
See wasmerio/napi#50 for the root-cause writeup and verification (standalone
V8 repro + before/after FinalizationRegistry/WeakRef fire-rate tests).
Stacked on #6844.