Bump napi: dispatch guest N-API finalizers (ECO-415) - #6823
Open
Arshia001 wants to merge 1 commit into
Open
Conversation
Arshia001
force-pushed
the
eco-415-guest-finalizers
branch
from
July 28, 2026 14:31
db65ae3 to
a22bf61
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the lib/napi git submodule to pull in wasmerio/napi#44, changing the Wasmer CLI鈥檚 N-API runtime behavior so guest finalizer callbacks are re-run during deferred finalizer draining (avoiding leaks for guest-owned allocations / wrapped objects on the V8-imports WASIX lane).
Changes:
- Bump
lib/napisubmodule revision to include updated guest finalizer dispatch behavior (napi_wrap,napi_add_finalizer,napi_create_external_{arraybuffer,buffer}). - No in-repo Rust/CLI code changes are expected beyond the submodule pointer update (per PR description).
Arshia001
force-pushed
the
eco-415-guest-finalizers
branch
from
July 28, 2026 14:54
a22bf61 to
1517865
Compare
Arshia001
force-pushed
the
eco-415-guest-finalizers
branch
from
July 28, 2026 16:10
1517865 to
7e8cb54
Compare
Arshia001
force-pushed
the
eco-415-guest-finalizers
branch
from
August 4, 2026 13:56
7e8cb54 to
e418254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule bump only: pulls wasmerio/napi#44 into the wasmer CLI's N-API runtime.
napi_wrap/napi_add_finalizer/napi_create_external_{arraybuffer,buffer}now re-run the guest's finalize callback on the deferred finalizer drain instead of dropping it, so guest-owned allocations and wrapped C++ objects are no longer leaked on the V8-imports WASIX lane (ECO-415).Verified via the edgejs v8-wasix node suite (1623 pass; new 6 GiB memory-pressure test) and a 40x teardown loop.
Stacked on
napi-value-scope-rework(ECO-416). Not independently mergeable yet.馃 Generated with Claude Code