fix(macOS): respect MTU on macOS in udp-large-recv test-case - #6786
Closed
marxin wants to merge 2 commits into
Closed
fix(macOS): respect MTU on macOS in udp-large-recv test-case#6786marxin wants to merge 2 commits into
udp-large-recv test-case#6786marxin wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the udp-large-recv WASIX socket test on macOS by ensuring the UDP payload size respects macOS loopback MTU limitations, while preserving the larger payload on Linux where loopback MTU is larger.
Changes:
- Introduces a
build.shforudp-large-recvthat compilesmain.cwith an OS-dependentPAYLOAD_SIZE(smaller on macOS). - Updates the WASIX wasm_tests harness to export
WASMER_HOST_OSfor build steps, enabling build scripts to tune compilation based on host OS. - Moves the test’s
ExpectedStdoutdirective frommain.cinto the newbuild.sh(matching the harness’##directive format for.shsources).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/wasix/tests/wasm_tests/socket/udp-large-recv/main.c | Removes hardcoded PAYLOAD_SIZE and relies on build-time -D from the build script. |
| lib/wasix/tests/wasm_tests/socket/udp-large-recv/build.sh | New build script selects payload size by host OS and compiles main.c accordingly; carries ExpectedStdout. |
| lib/wasix/tests/wasm_tests/mod.rs | Documents and implements WASMER_HOST_OS injection into the build environment. |
Collaborator
Author
|
Noticed #6785. |
Collaborator
Author
|
Superseded by #6789. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.