Skip to content

fix(macOS): respect MTU on macOS in udp-large-recv test-case - #6786

Closed
marxin wants to merge 2 commits into
mainfrom
macos-udp-large-recv
Closed

fix(macOS): respect MTU on macOS in udp-large-recv test-case#6786
marxin wants to merge 2 commits into
mainfrom
macos-udp-large-recv

Conversation

@marxin

@marxin marxin commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the udp-large-recv WASIX socket test on macOS by ensuring the UDP payload size respects macOS loopback MTU limitations, while preserving the larger payload on Linux where loopback MTU is larger.

Changes:

  • Introduces a build.sh for udp-large-recv that compiles main.c with an OS-dependent PAYLOAD_SIZE (smaller on macOS).
  • Updates the WASIX wasm_tests harness to export WASMER_HOST_OS for build steps, enabling build scripts to tune compilation based on host OS.
  • Moves the test’s ExpectedStdout directive from main.c into the new build.sh (matching the harness’ ## directive format for .sh sources).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/wasix/tests/wasm_tests/socket/udp-large-recv/main.c Removes hardcoded PAYLOAD_SIZE and relies on build-time -D from the build script.
lib/wasix/tests/wasm_tests/socket/udp-large-recv/build.sh New build script selects payload size by host OS and compiles main.c accordingly; carries ExpectedStdout.
lib/wasix/tests/wasm_tests/mod.rs Documents and implements WASMER_HOST_OS injection into the build environment.

@marxin

marxin commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

Noticed #6785.

@marxin

marxin commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #6789.

@marxin marxin closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants