chore: bump napi submodule: make GuestHeap the only V8 allocation path - #136
Merged
Merged
Conversation
Pulls in wasmerio/napi guest-heap-mandatory-alloc (also picks up the rest of the napi stack through eco-416-tls-handshake-exit, which this submodule was previously pinned behind). N-API instantiation for the native V8 build now fails outright if the guest has no linear memory or GuestHeap setup fails, instead of silently falling back to unbudgeted host-heap allocation for V8 backing stores.
Follow-up to the previous bump: with GuestHeap mandatory, TrackingArrayBufferAllocator's host-heap external-budget hook (napi_host_external_try_charge and friends) was unreachable and has been removed from napi.
This was referenced Jul 31, 2026
syrusakbary
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
napisubmodule to Make GuestHeap the only V8 allocation path; hard-fail if it can't be built napi#49 (guest-heap-mandatory-alloc), also fast-forwarding edgejs's own napi pin from a stale 612e204 up through the current stack tip. N-API instantiation for the native V8 build now fails outright if the guest has no linear memory or GuestHeap setup fails, instead of silently falling back to unbudgeted host-heap allocation for V8 backing stores. Also removes the now-dead array-buffer-allocator external-budget hook this made unreachable.Test plan
cargo test -p wasmer-napi --lib(36/36) andcargo check --features cligreen in the wasmer checkoutStacked on #133.
🤖 Generated with Claude Code