chore: Refactoring custom wasi implementation - #292
Merged
Conversation
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
Member
Author
|
This should help #115 ship |
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
ricochet
reviewed
Feb 20, 2026
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
ricochet
approved these changes
Feb 20, 2026
ricochet
left a comment
ricochet
left a comment
Contributor
There was a problem hiding this comment.
LGTM main thing we'll need to watch out for when doing wasmtime upgrades is that if new interfaces are added, we'll need to include those in our add_wasi_to_linker
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
lxfontes
force-pushed
the
lxfontes/wasi-upstream
branch
from
February 20, 2026 18:27
50083f7 to
d19d747
Compare
lxfontes
enabled auto-merge
February 20, 2026 18:48
lxfontes
disabled auto-merge
February 20, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making so only
wasi:socketsis customized.This allows using the upstream
wasmtime_wasicrate while customizing socket behaviour.The only custom code retained is the socket/loopback networking implementation, which was moved into crates/wash-runtime/src/sockets/.
ActiveCtx