feat: upgrade ed25519 to 2.2.3 - #53
Merged
Merged
Conversation
Signed-off-by: Abhijeet Prasad <aprasad@sentry.io>
brooksmtownsend
approved these changes
Jul 3, 2025
brooksmtownsend
left a comment
Member
There was a problem hiding this comment.
Hey @AbhiPrasad thanks for this PR!
I'm surprised that ed25519 didn't just update automatically to 2.2.3, but regardless this LGTM. Will you confirm that this fixes your issue so I can cut a patch release?
Contributor
Author
|
yup confirmed, validated with the following diff in https://github.com/vectordotdev/vector diff --git a/Cargo.toml b/Cargo.toml
index 4b19eecd9..6e2b9626c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -311,6 +311,9 @@ hex = { version = "0.4.3", default-features = false, optional = true }
# GreptimeDB
greptimedb-ingester = { git = "https://github.com/GreptimeTeam/greptimedb-ingester-rust", rev = "f7243393808640f5123b0d5b7b798da591a4df6e", optional = true }
+# Sentry
+sentry = { version = "0.41.0", default-features = false, optional = true, features = ["reqwest", "transport"] }
+
# External libs
arc-swap = { version = "1.7", default-features = false, optional = true }
async-compression = { version = "0.4.25", default-features = false, features = ["tokio", "gzip", "zstd"], optional = true }
@@ -363,7 +366,7 @@ maxminddb = { version = "0.26.0", default-features = false, optional = true, fea
md-5 = { version = "0.10", default-features = false, optional = true }
mongodb = { version = "2.8.2", default-features = false, features = ["tokio-runtime"], optional = true }
async-nats = { version = "0.33.0", default-features = false, optional = true }
-nkeys = { version = "0.4.4", default-features = false, optional = true }
+nkeys = { git = "https://github.com/wasmCloud/nkeys.git", default-features = false, optional = true }
nom = { workspace = true, optional = true }
notify = { version = "8.0.0", default-features = false, features = ["macos_fsevent"] }
openssl = { version = "0.10.73", default-features = false, features = ["vendored"] }
|
Member
|
Will cut release once #54 merges |
Member
|
@AbhiPrasad you should be good to go! https://crates.io/crates/nkeys/0.4.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Problem
I'm working on some things for https://github.com/vectordotdev/vector when I noticed a dependency conflict that came from
nkeys. This was resolved by bumpinged25519from2.0.0to2.2.3.CHANGELOG: https://github.com/RustCrypto/signatures/blob/master/ed25519/CHANGELOG.md
as the per the changelog, there were no notable changes to
ed25519that will affect this repo. Upgrading to2.2.3also aligns ontoed25519-dalek2.xas a common shared dep.Would appreciate if we could merge this in to unblock future work on vector. Thanks!
Full error message: