Skip to content

feat: upgrade ed25519 to 2.2.3 - #53

Merged
brooksmtownsend merged 1 commit into
wasmCloud:mainfrom
AbhiPrasad:main
Jul 3, 2025
Merged

feat: upgrade ed25519 to 2.2.3#53
brooksmtownsend merged 1 commit into
wasmCloud:mainfrom
AbhiPrasad:main

Conversation

@AbhiPrasad

@AbhiPrasad AbhiPrasad commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Feature or Problem

I'm working on some things for https://github.com/vectordotdev/vector when I noticed a dependency conflict that came from nkeys. This was resolved by bumping ed25519 from 2.0.0 to 2.2.3.

CHANGELOG: https://github.com/RustCrypto/signatures/blob/master/ed25519/CHANGELOG.md

as the per the changelog, there were no notable changes to ed25519 that will affect this repo. Upgrading to 2.2.3 also aligns onto ed25519-dalek 2.x as a common shared dep.

Would appreciate if we could merge this in to unblock future work on vector. Thanks!

Full error message:

error: failed to select a version for `der`.
    ... required by package `ureq v3.0.11`
    ... which satisfies dependency `ureq = "^3.0.11"` of package `sentry v0.41.0`
    ... which satisfies dependency `sentry = "^0.41.0"` (locked to 0.41.0) of package `vector v0.49.0 (/Users/abhijeetprasad/workspace/vector)`
versions that meet the requirements `^0.7.9` are: 0.7.10, 0.7.9

all possible versions conflict with previously selected packages.

  previously selected package `der v0.7.8`
    ... which satisfies dependency `der = "^0.7"` (locked to 0.7.8) of package `pkcs8 v0.10.2`
    ... which satisfies dependency `pkcs8 = "^0.10"` (locked to 0.10.2) of package `ed25519 v2.2.3`
    ... which satisfies dependency `ed25519 = "^2.0.0"` (locked to 2.2.3) of package `nkeys v0.4.4`
    ... which satisfies dependency `nkeys = "^0.4.4"` (locked to 0.4.4) of package `vector v0.49.0 (/Users/abhijeetprasad/workspace/vector)`

@AbhiPrasad
AbhiPrasad requested a review from a team as a code owner July 2, 2025 21:12
Signed-off-by: Abhijeet Prasad <aprasad@sentry.io>

@brooksmtownsend brooksmtownsend left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AbhiPrasad thanks for this PR!

I'm surprised that ed25519 didn't just update automatically to 2.2.3, but regardless this LGTM. Will you confirm that this fixes your issue so I can cut a patch release?

@brooksmtownsend
brooksmtownsend merged commit 839266b into wasmCloud:main Jul 3, 2025
4 checks passed
@AbhiPrasad

Copy link
Copy Markdown
Contributor Author

yup confirmed, validated with the following diff in https://github.com/vectordotdev/vector

diff --git a/Cargo.toml b/Cargo.toml
index 4b19eecd9..6e2b9626c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -311,6 +311,9 @@ hex = { version = "0.4.3", default-features = false, optional = true }
 # GreptimeDB
 greptimedb-ingester = { git = "https://github.com/GreptimeTeam/greptimedb-ingester-rust", rev = "f7243393808640f5123b0d5b7b798da591a4df6e", optional = true }
 
+# Sentry
+sentry = { version = "0.41.0", default-features = false, optional = true, features = ["reqwest", "transport"] }
+
 # External libs
 arc-swap = { version = "1.7", default-features = false, optional = true }
 async-compression = { version = "0.4.25", default-features = false, features = ["tokio", "gzip", "zstd"], optional = true }
@@ -363,7 +366,7 @@ maxminddb = { version = "0.26.0", default-features = false, optional = true, fea
 md-5 = { version = "0.10", default-features = false, optional = true }
 mongodb = { version = "2.8.2", default-features = false, features = ["tokio-runtime"], optional = true }
 async-nats = { version = "0.33.0", default-features = false, optional = true }
-nkeys = { version = "0.4.4", default-features = false, optional = true }
+nkeys = { git = "https://github.com/wasmCloud/nkeys.git", default-features = false, optional = true }
 nom = { workspace = true, optional = true }
 notify = { version = "8.0.0", default-features = false, features = ["macos_fsevent"] }
 openssl = { version = "0.10.73", default-features = false, features = ["vendored"] }

@brooksmtownsend

Copy link
Copy Markdown
Member

Will cut release once #54 merges

@brooksmtownsend

Copy link
Copy Markdown
Member

@AbhiPrasad you should be good to go! https://crates.io/crates/nkeys/0.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants