Optimize memory bounds checks on narrow targets - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
WebAssembly memory32 base addresses and instruction offsets are unsigned 32-bit values. The previous implementation promoted every effective address to
u64, which makes narrow targets such as AVR emit software 64-bit addition and comparison helpers for memory operations.The new narrow-target path detects 32-bit addition wraparound before validating the access size. It is selected by native pointer width rather than by any platform-specific AVR condition.
Impact
ATmega1284P build with float, fuel, and snapshots explicitly enabled:
The x86-64 build keeps the previous code path and its measured binary size is unchanged.
Validation