Fix Firefox WASI module loading - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ccallarray marshalling with explicit_malloc,HEAPU8.set, and_freeapp_main, WASI modules through_start, and conventional modules throughmainRoot cause
Firefox rejects
TextDecoder.decode()when Emscripten passes a view backed by resizable WebAssembly memory. The previous loader usedccallwith thearrayargument type and usedUTF8ToStringfor runtime errors, both of which can reach that incompatible decoding path.Fix
Guest bytes are now copied explicitly into Emscripten memory before calling
browser_task_create. Runtime error strings are copied into a normal non-resizableUint8Arraybefore decoding.The loader also inspects WebAssembly exports and chooses the first supported entry point in this order:
app_main_startmainThis allows
wasi_puts.wasmfromwasm-rtos-teststo use its correct_startexport.Validation
Do not merge until the JavaScript syntax check and complete Emscripten browser build succeed.