Skip to content

fix: don't fail exceptfds with ENOSYS, just zero them' #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kilyanni wants to merge 1 commit into from
Closed

fix: don't fail exceptfds with ENOSYS, just zero them' #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions libc-bottom-half/cloudlibc/src/libc/sys/select/pselect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@ int pselect(int nfds, fd_set *restrict readfds, fd_set *restrict writefds,
return -1;
}

// This implementation does not support polling for exceptional
// conditions, such as out-of-band data on TCP sockets.
if (errorfds != NULL && errorfds->__nfds > 0) {
errno = ENOSYS;
return -1;
}
// wasix poll_oneoff has no exceptional-condition (POLLPRI) event type, so we
// cannot report out-of-band data. Rather than fail the whole call with ENOSYS
// (which breaks defensive callers like rsync that always pass an exceptfds
// set and only treat EBADF as fatal, so ENOSYS spins their select loop),
// ignore exceptfds and report that no descriptor is exceptional.
if (errorfds != NULL)
FD_ZERO(errorfds);

// Replace NULL pointers by the empty set.
fd_set empty;
Expand Down
Loading