Fix final binaries leaking build paths - #123
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses build irreproducibility where absolute build-directory and LLVM install paths can leak into produced archives (via debug-info paths), preventing bit-for-bit reproducible outputs across different build environments. It does so by adding deterministic path remapping flags to the CMake builds for compiler-rt and libc++.
Changes:
- Detects Clang’s resource directory at build time and defines
-ffile-prefix-mapremappings for the repo root and resource dir. - Applies those remapping flags to CMake C/C++/ASM flags for the
compiler-rtbuild. - Applies those remapping flags to CMake C/C++/ASM flags for the
libcxx(LLVM runtimes) build.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Arshia001
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small irreproducibility issue I noticed while packaging this with Nix:
The final binaries leak paths to the build directory, meaning binaries aren't directly bit-for-bit reproducible.
This PR adds path maps so that the build is idempotent over the build directory path & clang resource dir path.
Should not change behavior.