fix: decode request path before SigV4 canonicalization - #9
Merged
Conversation
theduke
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth path fed
hyper's raw (percent-encoded) request path intocreate_canonical_request, whichuri_encodes it a second time. Any keywith a reserved char was thus double-encoded (e.g.
+->%2B->%252B),so the server's canonical URI no longer matched the client's and every
such request failed with
SignatureDoesNotMatch.Checked against rclone: a
+object key returns 403 before thischange and is accepted after; a plain key is accepted both ways.