Skip to content

fix: don't fail PutObject when the metadata sidecar can't be written #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kilyanni wants to merge 1 commit into from
Closed

fix: don't fail PutObject when the metadata sidecar can't be written #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/storages/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use md5::{Digest, Md5};
use path_absolutize::Absolutize;
use rusoto_s3::CommonPrefix;
use tokio::io::{AsyncReadExt, AsyncSeekExt, AsyncWrite, AsyncWriteExt, BufWriter};
use tracing::{debug, error};
use tracing::{debug, error, warn};
use uuid::Uuid;

use tokio::fs;
Expand Down Expand Up @@ -758,7 +758,13 @@ impl S3Storage for FileSystem {
);

if let Some(ref metadata) = metadata {
trace_try!(self.save_metadata(&bucket, &key, metadata).await);
// The metadata sidecar lives at the fs-root, which may be read-only
// (e.g. an Edge volume is mounted at the bucket, not the root). The
// object itself is already written, so a failed sidecar write should
// not fail the whole PUT
Comment on lines 760 to +764
if let Err(err) = self.save_metadata(&bucket, &key, metadata).await {
warn!(%bucket, %key, %err, "could not persist object metadata; object stored without it");
}
}

let output = PutObjectOutput {
Expand Down
Loading