fix: download wasm-opt on aarch64 Linux - #86
Merged
Conversation
install_wasm_opt only mapped four hosts, so aarch64 Linux fell through
to the bail arm and every cargo-wasix build died in post-processing:
no precompiled binaries of `wasm-opt` are available for this
platform, you'll want to set `$WASM_OPT` to a preinstalled
`wasm-opt` command or disable via `wasm-opt = false` in your
manifest
binaryen has published binaryen-version_130-aarch64-linux.tar.gz all
along, so this is just a missing arm.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the
linux+aarch64arm toinstall_wasm_optinsrc/lib.rs, mapping to binaryen'saarch64-linuxasset.Why
Follow-up to #85. With the host toolchain fixed,
cargo wasix buildgets all the way to post-processing on aarch64 Linux and then dies:install_wasm_optmapped onlyx86_64-linux,x86_64-macos,arm64-macosandx86_64-windows, so aarch64 Linux hit thebail!arm. Binaryen has shippedbinaryen-version_130-aarch64-linux.tar.gzall along — I confirmed the URL this arm constructs returns HTTP 200.Without this, every Rust build on an aarch64 Linux host fails. It took out all 708 Rust test-fixture trials in wasmerio/wasmer#6698: https://github.com/wasmerio/wasmer/actions/runs/31015208374
Notes
As with #85, no version bump here — a crates.io release is needed before the
wasix-org/cargo-wasixaction picks it up.🤖 Generated with Claude Code