2fa improvements#110
Open
wasafiri wants to merge 224 commits into
Open
Conversation
…e to use traditional Rails flash messages.
…able_content to fix deprecation warnings; disable test parallelization
…get all working properly
…ejections may proceed without a file. Updated docs
…ating an application, such as when rejecting application for income; add data-range controller for vendor_portal index view filter
…licative tests; update README
…coverage - Updated test names for clarity in proof email submission tests. - Consolidated email ingestion tests to ensure proper handling of attachments. - Enhanced rejection reason tests with detailed debugging information and better waiting. - Added checks for proof attachment visibility and modal interactions. - Fixed dependent selection tests to verify UI changes accurately. - Updated disability validation tests to check for proper form submission conditions. - Added tests for resubmitting rejected proofs and authentication requirements.
…ld calculations; implement lazy loading for chart controllers
… loading in reporting_service.rb
…ertification forms - Updated database schema to include fields for document signing status and related metadata. - Implemented DocumentSigning::SubmissionService to handle document signing requests. - Created webhook controller to process events from DocuSeal. - Added integration tests for the document signing workflow, including success and failure scenarios. - Developed model tests for Application to validate document signing status transitions and request counts. - Created view helper for displaying document signing status badges. - Implemented tests for the document signing helper and service. - Ensured proper handling of API errors and duplicate requests in the submission service.
…for fork safety; enhance README; update Tailwind config to set default font
- New view for displaying dependents of guardians in dependents.html.erb - Update user index view to improve table layout and added relationship details for guardians and dependents. - Update search view for users to facilitate guardian search functionality. - Show user.effective_email for dependents - Fix W9 review page to correctly load PDF documents. - Modify queue configuration to optimize thread usage in development. - Enhance application audit log tests to verify document signing requests. - Add autosave service tests to ensure draft applications are handled correctly. - Improve system test helpers for better page load verification. - Update various system tests to reflect changes in UI and field IDs for dependent and guardian management.
- Remove legacy AJAX endpoint for FPL thresholds in favor of server-rendered data. - Update controller methods to provide FPL data as JSON for client-side validation. - Add checks for existing drafts and active applications. - Tweak view to hide application button when application exists and show proper (apply/start, continue, view) button based on application status - Update tests to ensure correct functionality of FPL helper methods
- Update error message display in edit and new to improve screen reader accessibility - Improve visibility of errors upon form submission - Clarify image alt text in the home index view - Use skip link for better navigation in user profile edit view
…nd adding dependent relationship methods - Limit user loading to 50 per page - Tweaks to support new role and capability update URLs
…er type handling during changes
- Clean up queue_schema.rb to only contain Solid Queue tables, removing application tables - Add migrations_paths for queue database in test/production - Create db/queue_migrate and db/cable_migrate directories - Move Solid Queue migration to db/queue_migrate/ - Add Solid Cable migration to db/cable_migrate/ - Update cable_schema.rb version to match migration Should fix CI failures where email_templates.enabled column was missing
Fix/queue schema email templates column
- Add contact method feedback controller for real-time confirmation messages - Add preferred means of communication and referral source fields to user model - Enhance paper application form with better accessibility and UX - Update test factory - Add contact delivery preference feedback (email vs mail) This improves the experience when entering paper applications by clarifying the difference betwen the different contact/communication options and providing immediate visual feedback about contact preferences and delivery methods
The column already exists in the main branch, so this migration is unnecessary
- Remove RAILS_MASTER_KEY reference that causes context access error - Test environment generates temporary keys automatically - Change db:prepare to db:setup for more reliable migration handling
…rovements Improve paper application form UX with contact feedback
…ents - Skip ProofReview notifications when Current.paper_context is true - Skip ProofAttachmentService notifications in paper context - Guard ProofReview notifications with association presence checks - Keep notifiable as Application for query consistency - Add contact_feedback_target to dependent form address fields - Restore display:none fallback in setVisible utility
…solid-cache Fix duplicate notifications in paper application flow with nil recipients
Initial addition of required field markers
Update seed policies for user
- Add hidden field to preserve modal parameter during form submission
- Fix controller logic to return head :ok for modal requests instead of redirecting
- Standardize application display across user show page (detailed status badges, consistent font sizes)
- Add "Last updated" timestamp to all application displays
- Change section heading to "{User.first_name}'s Applications" for clarity
- Fix memory leak in application_modal_controller by storing bound event handler
- Add null checks for dialog elements to prevent TypeError
- Add aria-label attributes to modal close and cancel buttons
- Remove click-outside-to-close behavior from critical modals for accessibility
- Ensure all edit forms have valid turbo_frame_tag with fallback IDs
Added live keydown searching to manage users
fix: improve modal editing and UI consistency
Handle missing items in paper application
Users page with applications, ability to edit applications, users
Clarify and standardize 2FA setup/verification copy, simplify WebAuthn setup guidance, and align SMS/TOTP flows with plain-language messaging. Migrate SMS 2FA to Twilio Verify with safer verification handling, consistent resend behavior, and better error reporting, and update system tests to reflect the new UX.
The sms_code_expired? method is no longer needed as Twilio Verify API handles code expiration internally. The service returns error code 60200 for expired codes, eliminating the need for local expiration checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve 2FA setup flow and Twilio Verify integration