Feature/enable twilio sms integration#109
Open
wasafiri wants to merge 156 commits into
Open
Conversation
…e to use traditional Rails flash messages.
…able_content to fix deprecation warnings; disable test parallelization
…get all working properly
…ejections may proceed without a file. Updated docs
…ating an application, such as when rejecting application for income; add data-range controller for vendor_portal index view filter
…licative tests; update README
…coverage - Updated test names for clarity in proof email submission tests. - Consolidated email ingestion tests to ensure proper handling of attachments. - Enhanced rejection reason tests with detailed debugging information and better waiting. - Added checks for proof attachment visibility and modal interactions. - Fixed dependent selection tests to verify UI changes accurately. - Updated disability validation tests to check for proper form submission conditions. - Added tests for resubmitting rejected proofs and authentication requirements.
…ld calculations; implement lazy loading for chart controllers
… loading in reporting_service.rb
…ertification forms - Updated database schema to include fields for document signing status and related metadata. - Implemented DocumentSigning::SubmissionService to handle document signing requests. - Created webhook controller to process events from DocuSeal. - Added integration tests for the document signing workflow, including success and failure scenarios. - Developed model tests for Application to validate document signing status transitions and request counts. - Created view helper for displaying document signing status badges. - Implemented tests for the document signing helper and service. - Ensured proper handling of API errors and duplicate requests in the submission service.
…for fork safety; enhance README; update Tailwind config to set default font
- New view for displaying dependents of guardians in dependents.html.erb - Update user index view to improve table layout and added relationship details for guardians and dependents. - Update search view for users to facilitate guardian search functionality. - Show user.effective_email for dependents - Fix W9 review page to correctly load PDF documents. - Modify queue configuration to optimize thread usage in development. - Enhance application audit log tests to verify document signing requests. - Add autosave service tests to ensure draft applications are handled correctly. - Improve system test helpers for better page load verification. - Update various system tests to reflect changes in UI and field IDs for dependent and guardian management.
- Remove legacy AJAX endpoint for FPL thresholds in favor of server-rendered data. - Update controller methods to provide FPL data as JSON for client-side validation. - Add checks for existing drafts and active applications. - Tweak view to hide application button when application exists and show proper (apply/start, continue, view) button based on application status - Update tests to ensure correct functionality of FPL helper methods
- Update error message display in edit and new to improve screen reader accessibility - Improve visibility of errors upon form submission - Clarify image alt text in the home index view - Use skip link for better navigation in user profile edit view
…nd adding dependent relationship methods - Limit user loading to 50 per page - Tweaks to support new role and capability update URLs
…er type handling during changes
Fix evaluators dashboard redirect
Fixed broken dashboard link in trainer view
Email templates check variables
… of direct modal replacements; improve error handling; refactor InvoicesController error handling into handle_update_error method; add explicit error messages for validation failures; fix missing_gad_reference? guard
- Replace turbo_modals_to_remove with 'modals' => 'modals' pattern - Modals are now replaced (not removed), allowing them to be reopened - Remove unused methods: standard_application_modals, build_proof_review_success_streams - Mark turbo_modals_to_remove parameter as deprecated - Update tests to expect modal container replacement instead of individual removals Fixes the issue where modals couldn't be reopened after approving/rejecting proofs.
- Add constituent_full_name required by proof_rejected template - Replace nil with empty strings for optional variables to prevent removal by .compact - Fixes rejection emails failing with ArgumentError - Fixes approval emails showing raw placeholder text
…bles Fix missing email template variables
Refactor modal handling to use turbo_modals_to_remove; other fixes
Creates db:seed_policies rake task that seeds Policy records without requiring FactoryBot, enabling production deployment on Heroku and similar platforms. The existing db:seed command requires factory_bot_rails which is only available in the test group, causing LoadError in production. Changes: - Add lib/tasks/seed_policies.rake with production-safe task that uses find_or_initialize_by - Update README.md with Production Deployment section documenting both policy and email template seeding for production environments - Include clear warnings about not running db:seed in production - Add instructions for creating admin users in production console The task is idempotent and can be run multiple times safely.
…eeding Add production-safe policy seeding rake task
Fixes to locale according to Rubocop report
removed About and Contact buttons from _header
Added Favicon
Added skip to application table button for keyboard users
Fixed translation error for signin_pass message
- Update SmsService to use actual Twilio API instead of stub - Add twilio_configured? check for graceful fallback in test/dev - Add sms_from_number to Twilio configuration - Remove fax_from_number as Twilio does not do faxes anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace stubs with Twilio API, add Twilio_configured? check, add sms_from_number and remove fax_from_number.