fix: delete compliance-pipeline/'s hardcoded 64-GUID mapper (B6) - #55
Merged
Conversation
compliance-pipeline/ was a fourth, fully standalone mapping stack with its own policy_mapper.py hardcoding a 64-GUID menu (32 overlapping the backend's pre-B1 34-GUID menu) - the same defect B1 fixed in the backend pipeline, at larger scale, in a copy nothing in app/ imports or references (confirmed: no code or test under app/ touches it). Deleted the whole directory rather than reworking it to delegate to AIMappingService: it has its own requirements.txt and entry point, never shared a runtime with the backend, and nothing depends on it. Hardcoding a policy shortlist is exactly the failure mode the AI mapping engine exists to avoid - a curated list caps recall at whatever its author thought of, against a catalogue of 2,467 shipped definitions. Removed its two remaining references in README.md and docs/FUNCTIONAL_SPEC.md. There is now exactly one mapping engine in the repository (AIMappingService), reached by both the services path and the pipeline path (B1). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 39bc839d-c643-40f2-b8a7-a7e524d91ed6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compliance-pipeline/was a fourth, fully standalone mapping stack with its ownpolicy_mapper.pyhardcoding a 64-GUID menu (32 overlapping the backend's pre-B1 34-GUID menu) — the same defect B1 fixed in the backend pipeline, at larger scale, in a copy nothing inapp/imports or references.Decision: deleted, not delegated
Per explicit direction: hardcoding a policy shortlist voids the reason the AI mapping engine exists — a curated list caps recall at whatever its author thought of, against a catalogue of 2,467 shipped definitions.
Confirmed before deleting: no code or test under
app/(backend, frontend, or tests) imports or referencescompliance-pipeline/— it's a fully standalone CLI tool with its ownrequirements.txtand entry point (pipeline.py), never sharing a runtime with the backend. Reworking it to delegate toAIMappingServicewould mean building and maintaining a second integration surface into the shared mapping engine for a tool nothing else depends on, so it's deleted outright:pipeline.py,policy_mapper.py,control_extractor.py,pdf_extractor.py,initiative_builder.py,validator.py,models.py,config.py, itsrequirements.txt,.env.template, andREADME.md.README.mdanddocs/FUNCTIONAL_SPEC.md(## 8. Known limitations) removed.There is now exactly one mapping engine in the repository (
AIMappingService), reached by both the services path and the pipeline path (B1).Testing
Re-ran the pipeline/mapping/initiative test groups to confirm nothing depended on the deleted directory — 91 passed, no regressions.