Enable Windows video recording in release builds - #16260
Conversation
WindowsVideoRecording was only in DOGFOOD_FLAGS, so stable clients on Windows cloud runners never advertised the recording tools and the computer-use agent could take screenshots but not record video. Co-Authored-By: Warp <agent@warp.dev>
|
@joeywangzr, Warp CI failed. May varoon's factory diagnose it, commit a fix, and push to this PR's existing branch? Explicit consent also opts this PR into automatic handling of future failures. Please reply here with clear permission and mention @warp-staging-factory. Responding as varoon's factory: Open session · View in factory |
|
@joeywangzr May windows runner test diagnose the failed Warp CI run, commit fixes, and push them to this same PR branch? Explicit consent also opts this PR into automatic handling of future CI failures. Please reply here with your decision and mention @warp. Responding as windows runner test: Open session · View in factory |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR enables FeatureFlag::WindowsVideoRecording in release bundles so Windows builds that already have VideoRecording enabled can advertise the recording tools.
Concerns
- No blocking concerns found. The diff only updates the release feature-flag list, adds no comments or tests, and has no approved spec context to validate against.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
Adds
FeatureFlag::WindowsVideoRecordingtoRELEASE_FLAGS, next toVideoRecording.On Windows,
video_recording_enabled()requires bothVideoRecordingandWindowsVideoRecording. OnlyVideoRecordingis inRELEASE_FLAGS;WindowsVideoRecordingis dogfood-only. So a stable client on a Windows cloud runner never advertisesStartRecording/StopRecordingin its supported tools, and the server leavesstart_recording/stop_recordingout of the computer-use agent's toolset. Screenshots don't use either flag, which is why they work while video doesn't.The Windows
gdigrabrecorder itself is already in stable (crates/computer_use/src/windows/recording.rs), andffmpeg.exeships in the Windows sidecar image. This change only flips the rollout gate. The flag stays inDOGFOOD_FLAGS, and it can still be turned back off independently of the macOS and Linux recorders by removing this line.Linked Issue
ready-to-specorready-to-implement.Testing
cargo nextest run -p warp_features: passes.cargo clippy -p warp_features --all-targets --tests -- -D warnings: clean.I did not run the Windows recorder end to end with this flag on a stable build, and I did not run the app locally. The behavior was traced through the code: the client gate in
recording_controller.rs, the supported-tools list inai/agent/api/impl.rs, and the server'sAreToolTypesSupportedcheck for the computer-use agent.Please confirm with the REMOTE-2064 owner that Windows recording is ready for stable before merging. Windows cloud runners now run the agent in the logged-in desktop session (Namespace enabled interactive applications on the prod workspace), which
gdigrabneeds. A staging run with a Dev client, where the flag is already on, is a good check.I have manually tested my changes locally with
./script/runAgent Mode