Skip to content

Enable Windows video recording in release builds - #16260

Merged
joeywangzr merged 1 commit into
masterfrom
jopee/enable-windows-video-recording
Oct 2, 2026
Merged

joeywangzr merged 1 commit into
masterfrom
jopee/enable-windows-video-recording

Conversation

@joeywangzr

Copy link
Copy Markdown
Contributor

Description

Adds FeatureFlag::WindowsVideoRecording to RELEASE_FLAGS, next to VideoRecording.

On Windows, video_recording_enabled() requires both VideoRecording and WindowsVideoRecording. Only VideoRecording is in RELEASE_FLAGS; WindowsVideoRecording is dogfood-only. So a stable client on a Windows cloud runner never advertises StartRecording / StopRecording in its supported tools, and the server leaves start_recording / stop_recording out of the computer-use agent's toolset. Screenshots don't use either flag, which is why they work while video doesn't.

The Windows gdigrab recorder itself is already in stable (crates/computer_use/src/windows/recording.rs), and ffmpeg.exe ships in the Windows sidecar image. This change only flips the rollout gate. The flag stays in DOGFOOD_FLAGS, and it can still be turned back off independently of the macOS and Linux recorders by removing this line.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • cargo nextest run -p warp_features: passes.

  • cargo clippy -p warp_features --all-targets --tests -- -D warnings: clean.

  • I did not run the Windows recorder end to end with this flag on a stable build, and I did not run the app locally. The behavior was traced through the code: the client gate in recording_controller.rs, the supported-tools list in ai/agent/api/impl.rs, and the server's AreToolTypesSupported check for the computer-use agent.

  • Please confirm with the REMOTE-2064 owner that Windows recording is ready for stable before merging. Windows cloud runners now run the agent in the logged-in desktop session (Namespace enabled interactive applications on the prod workspace), which gdigrab needs. A staging run with a Dev client, where the flag is already on, is a good check.

  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

WindowsVideoRecording was only in DOGFOOD_FLAGS, so stable clients on
Windows cloud runners never advertised the recording tools and the
computer-use agent could take screenshots but not record video.

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Oct 2, 2026
@joeywangzr
joeywangzr marked this pull request as ready for review October 2, 2026 16:43
@warp-agent-staging

Copy link
Copy Markdown
Contributor

@joeywangzr, Warp CI failed. May varoon's factory diagnose it, commit a fix, and push to this PR's existing branch? Explicit consent also opts this PR into automatic handling of future failures. Please reply here with clear permission and mention @warp-staging-factory.

Responding as varoon's factory: Open session · View in factory

@warp-factories

warp-factories Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@joeywangzr May windows runner test diagnose the failed Warp CI run, commit fixes, and push them to this same PR branch? Explicit consent also opts this PR into automatic handling of future CI failures. Please reply here with your decision and mention @warp.

Responding as windows runner test: Open session · View in factory

@warp-agent-staging warp-agent-staging Bot added the factory-ci-permission-pending Awaiting PR author consent for factory CI diagnosis and branch fixes label Oct 2, 2026
@joeywangzr
joeywangzr requested a review from vkodithala October 2, 2026 16:44
@warp-for-oss

warp-for-oss Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

@joeywangzr

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@joeywangzr
joeywangzr requested a review from bnavetta October 2, 2026 16:44
@joeywangzr
joeywangzr enabled auto-merge (squash) October 2, 2026 16:46

@warp-for-oss warp-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR enables FeatureFlag::WindowsVideoRecording in release bundles so Windows builds that already have VideoRecording enabled can advertise the recording tools.

Concerns

  • No blocking concerns found. The diff only updates the release feature-flag list, adds no comments or tests, and has no approved spec context to validate against.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@joeywangzr
joeywangzr merged commit c157d41 into master Oct 2, 2026
81 of 88 checks passed
@joeywangzr
joeywangzr deleted the jopee/enable-windows-video-recording branch October 2, 2026 17:47
@warp-agent-staging warp-agent-staging Bot removed the factory-ci-permission-pending Awaiting PR author consent for factory CI diagnosis and branch fixes label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants