Repository navigation
refactor(sve): P6 存量迁移收官——142 文件框架层化 + 拓扑修复 + 终审闭环 (all-VL Phase 2) #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
12ae1ce
e5a8473
2a4c438
9dab56e
43873e3
d322906
10339ae
6305332
e91508e
dd151e1
24a6151
1d75c1d
54aa4ce
fb89ae8
736e9f8
40a10c8
6aa6250
608194e
ea59e35
248154d
2212e3f
ada5ff7
154320a
43301b3
221948a
6ceaac9
b6695be
91886ca
312a33d
d8c9073
9e33944
da4435c
2637707
2b15e13
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,14 +143,21 @@ if host_machine.cpu_family() == 'aarch64' | |
| # such as this Kunpeng 920. Every test self-gates in test_init and | ||
| # returns a clean EXIT_SKIP on SVE-less CPUs, so their SVE | ||
| # codegen only ever executes on SVE-capable hardware. Built only on | ||
| # aarch64. (Gate split as of all-VL Phase 2: the P3 files gate via | ||
| # the framework layer — arm64_require_sve_vl: HWCAP_SVE capability + | ||
| # 128..1024-bit range in one call; the remaining legacy files still | ||
| # probe HWCAP_SVE by hand and migrate in P6.) | ||
| # aarch64. (Gate split as of all-VL Phase 2 P6: every SVE1 test in | ||
| # this library gates via the framework layer — arm64_require_sve_vl: | ||
| # HWCAP_SVE capability + 128..1024-bit range in one call. The only | ||
| # getauxval hand-probes left under tests/cpu/arm64/ are the SVE2 | ||
| # composite-gate files sve512_fmmla_arm/sve2_cross_precision_arm | ||
| # (tests_arm64_sve2 below): their SVE2|F32MM|F64MM / SVE2|SVEBF16 | ||
| # HWCAP2 conjunctions are the tests' own semantics and stay hand- | ||
| # probed by design, while their pure-SVE gate goes through the | ||
| # require helper.) | ||
| # | ||
| # NOTE: sve512_fma_arm.cpp is committed (ea879f68) but deliberately NOT | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [claude] [Minor] 可维护性: d8e6f62 对 sve512_fma_arm.cpp 做了全 VL 化功能改写(require 门控 + lanes 换算 + 漂移守卫),但该文件仍不在任何 sources 列表——PR「全量构建零告警」的验证链根本编译不到它,改写代码零构建验证(腐化风险而非即期错误:本人以同级 build 头文件 -fsyntax-only -march=armv8.2-a+sve 复核通过,EXIT=0)。 |
||
| # wired into any sources list yet — wiring + all-VL validation is | ||
| # scheduled for all-VL Phase 2 P3 | ||
| # wired into any sources list yet — its source side was migrated to | ||
| # the all-VL form in P6 batch C (require + lanes + drift guard, commit | ||
| # d8e6f625), so wiring it in only needs the meson entry plus the | ||
| # all-VL validation run; the original wiring plan (P3) lapsed unclaimed | ||
| # (docs/superpowers/specs/2026-10-23-sve-sme-all-vl2-design.md §6). | ||
| arm64_sve_lib = static_library( | ||
| 'tests_arm64_sve', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[claude] [Minor] 可维护性: 本 PR 重写了 sve512_fma_arm.cpp 的 init 门控、lanes 换算与 run 漂移守卫,但该文件不在任何 sources 列表里,"全量构建零告警" 的验证声明在结构上覆盖不到这个被修改的 TU。
证据: meson.build:156 注释明言 "sve512_fma_arm.cpp is committed (ea879f6) but deliberately NOT wired into any sources list yet",grep 全仓 meson 无第二处引用;而 diff 对 tests/cpu/arm64/sve512_fma_arm.cpp 有实质改动(require 门 +
data->vl_d = (size_t)svl / 8+ run 侧svcntd() != d->vl_d守卫)——改动只经人工单编(如有)而不过构建,接线前任何语法/头文件回归都不会被 CI 拦截。