Skip to content

fix: prevent "Bad state: Cannot add event after closing" in MdkVideoPlayer #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: prevent "Bad state: Cannot add event after closing" in MdkVideoPlayer #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b17801b
Initial plan
Copilot Aug 7, 2026
2e94c03
fix: guard StreamController.add/addError calls after close in MdkVide…
Copilot Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 51 additions & 30 deletions lib/src/video_player_mdk.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ class MdkVideoPlayer extends mdk.Player {
if (size == null) {
return;
}
if (streamCtl.isClosed) {
return;
}
streamCtl.add(VideoEvent(
eventType: VideoEventType.initialized,
duration: Duration(
Expand All @@ -74,10 +77,14 @@ class MdkVideoPlayer extends mdk.Player {
});
} else if (!oldValue.test(mdk.MediaStatus.buffering) &&
newValue.test(mdk.MediaStatus.buffering)) {
streamCtl.add(VideoEvent(eventType: VideoEventType.bufferingStart));
if (!streamCtl.isClosed) {
streamCtl.add(VideoEvent(eventType: VideoEventType.bufferingStart));
}
} else if (!oldValue.test(mdk.MediaStatus.buffered) &&
newValue.test(mdk.MediaStatus.buffered)) {
streamCtl.add(VideoEvent(eventType: VideoEventType.bufferingEnd));
if (!streamCtl.isClosed) {
streamCtl.add(VideoEvent(eventType: VideoEventType.bufferingEnd));
}
}
});

Expand All @@ -87,11 +94,13 @@ class MdkVideoPlayer extends mdk.Player {
if (ev.category == "reader.buffering") {
final pos = position;
final bufLen = buffered();
streamCtl.add(
VideoEvent(eventType: VideoEventType.bufferingUpdate, buffered: [
DurationRange(
Duration(microseconds: pos), Duration(milliseconds: pos + bufLen))
]));
if (!streamCtl.isClosed) {
streamCtl.add(
VideoEvent(eventType: VideoEventType.bufferingUpdate, buffered: [
DurationRange(
Duration(microseconds: pos), Duration(milliseconds: pos + bufLen))
]));
}
}
});

Expand All @@ -100,12 +109,16 @@ class MdkVideoPlayer extends mdk.Player {
'$hashCode player$nativeHandle onPlaybackStateChanged: ${event.oldValue} => ${event.newValue}');
if (event.newValue == mdk.PlaybackState.stopped) {
// FIXME: keep_open no stopped
streamCtl.add(VideoEvent(eventType: VideoEventType.completed));
if (!streamCtl.isClosed) {
streamCtl.add(VideoEvent(eventType: VideoEventType.completed));
}
return;
}
streamCtl.add(VideoEvent(
eventType: VideoEventType.isPlayingStateUpdate,
isPlaying: event.newValue == mdk.PlaybackState.playing));
if (!streamCtl.isClosed) {
streamCtl.add(VideoEvent(
eventType: VideoEventType.isPlayingStateUpdate,
isPlaying: event.newValue == mdk.PlaybackState.playing));
}
});
}
}
Expand Down Expand Up @@ -333,10 +346,12 @@ class MdkVideoPlayerPlatform extends VideoPlayerPlatform {
if (ret < 0) {
// no throw, handle error in controller.addListener
_players[-hashCode] = player;
player.streamCtl.addError(PlatformException(
code: 'media open error',
message: 'invalid or unsupported media',
));
if (!player.streamCtl.isClosed) {
player.streamCtl.addError(PlatformException(
code: 'media open error',
message: 'invalid or unsupported media',
));
}
//player.dispose(); // dispose for throw
return -hashCode;
}
Expand All @@ -349,10 +364,12 @@ class MdkVideoPlayerPlatform extends VideoPlayerPlatform {
final size = await player.textureSize;
if (size == null || size.width <= 0 || size.height <= 0) {
_players[-hashCode] = player;
player.streamCtl.addError(PlatformException(
code: 'video size error',
message: 'invalid or unsupported media with invalid video size',
));
if (!player.streamCtl.isClosed) {
player.streamCtl.addError(PlatformException(
code: 'video size error',
message: 'invalid or unsupported media with invalid video size',
));
}
return -hashCode;
}
final id = player.nativeHandle;
Expand Down Expand Up @@ -407,10 +424,12 @@ class MdkVideoPlayerPlatform extends VideoPlayerPlatform {
fit: _fitMaxSize);
if (tex < 0) {
_players[-hashCode] = player;
player.streamCtl.addError(PlatformException(
code: 'video size error',
message: 'invalid or unsupported media with invalid video size',
));
if (!player.streamCtl.isClosed) {
player.streamCtl.addError(PlatformException(
code: 'video size error',
message: 'invalid or unsupported media with invalid video size',
));
}
//player.dispose();
return -hashCode;
}
Expand Down Expand Up @@ -460,13 +479,15 @@ class MdkVideoPlayerPlatform extends VideoPlayerPlatform {
final pos = player.position;
final bufLen = player.buffered();
final ranges = player.bufferedTimeRanges();
player.streamCtl.add(VideoEvent(
eventType: VideoEventType.bufferingUpdate,
buffered: ranges +
[
DurationRange(Duration(milliseconds: pos),
Duration(milliseconds: pos + bufLen))
]));
if (!player.streamCtl.isClosed) {
player.streamCtl.add(VideoEvent(
eventType: VideoEventType.bufferingUpdate,
buffered: ranges +
[
DurationRange(Duration(milliseconds: pos),
Duration(milliseconds: pos + bufLen))
]));
}
return Duration(milliseconds: pos);
}

Expand Down