馃悰 fix gcs shallow search - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches GCS listing behavior (delimiter handling and response parsing), which can change which objects callers see; risk is moderate but scoped and covered by new unit tests.
Overview
list_files(and underlying async helpers) now supports arecursiveflag to control whether GCS listings are shallow (default, usingdelimiter='/') or recursive (no delimiter).The listing implementation is hardened to handle responses that omit the
itemskey (e.g., when onlyprefixesare returned), and new unit tests cover recursive vs shallow parameter behavior and the prefix-only edge case.Reviewed by Cursor Bugbot for commit 47f902e. Bugbot is set up for automated code reviews on this repo. Configure here.