test(trace): cover gen_ai.output.messages on turn and teammate spans - #170
Open
rgao-coreweave wants to merge 1 commit into
Open
test(trace): cover gen_ai.output.messages on turn and teammate spans#170rgao-coreweave wants to merge 1 commit into
rgao-coreweave wants to merge 1 commit into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 14, 2026
Both attributes were unasserted: replacing either value with undefined
left the whole suite green. Subagent spans were already well covered
(25 failures under the same mutation), so this fills the turn-side gap
only.
Pins the current wire format ahead of moving these writes onto the
SDK's record({outputMessages}).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rgao-coreweave
force-pushed
the
cover-turn-output-messages
branch
from
August 14, 2026 18:57
f23703e to
53a7889
Compare
rgao-coreweave
marked this pull request as ready for review
August 14, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds two missing assertions on
gen_ai.output.messages. Tests only, nosrc/change.The gap
Neither the turn span nor the teammate turn span had this attribute asserted anywhere. Found by mutation: replacing the written value with
undefinedleft all 203 tests green in both cases.The many existing
ATTR.OUTPUT_MESSAGESassertions all sit on subagent spans, never on the turn.emitTeammateitself runs 564 times across the suite, so the path was well exercised but the attribute was simply never checked.Subagent spans are not part of this gap. The same mutation applied to all three subagent writers produces 25 failures, so that side is already well covered and needs nothing here.
One correction worth recording: my first probe of
emitTeammateused athrowand reported zero hits. Acatchupstream swallowed it. Re-probing with a filesystem write gave the real 564.After
Each new assertion now fails under its mutation and passes on real code.
Why ahead of the refactor
These pin the current hand-rolled wire format. They pass with
src/byte-identical tomain, so the next PR in the stack is provably a no-op on the wire rather than being self-certified by tests written alongside it.Verification
tsc clean, 203/203 pass, and
git diff main -- src/is empty on this branch.🤖 Generated with Claude Code