fix(portal2): keep simple PID signing materials off the browser - #2186
fix(portal2): keep simple PID signing materials off the browser#2186JakeFernandes98 wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Summary
This stops Portal2 from shipping German, France Identité, and EUDI Reference Wallet private keys and certificates in the browser bundle. Simple PID create now sends only a material id plus a secret-free payload; Portal2 injects the signing materials from server-only env and redacts
key,x5c, andverifier_infofrom that create response.Fixes WAL-1382. The keys were previously hardcoded in
simplePidVerificationRequests.tsand visible in page JS and the Network tab.What Changed
Simple PID client
/api/pid-verification-session/createwith a material id.basic-pidstays unsigned and sends no material.NUXT_PUBLIC_VERIFIER_*keys directly to verifier2.Portal2 server
NUXT_PID_*materials, strips any client-supplied secrets, injects key/x5c/clientId/verifierInfo, and forwards to verifier2.NUXT_VERIFIER_PROXY_TARGET, otherwise an absoluteNUXT_PUBLIC_VERIFIER_BASE.Deploy
.env.exampledocument emptyNUXT_PID_*placeholders.portal2.envadds the same placeholders. Live key material is not in this PR.Architecture Notes
/verifier-apiwould hide advanced keys as well and was intentionally avoided.Caveats and Follow-Ups
NUXT_PID_*env is unset.Breaking
NUXT_PID_*environment variables. Unsignedbasic-pidis unchanged.