[WAL-1347] feat(mdoc): implement NFC proximity transport - #2165
Draft
szijpeter wants to merge 13 commits into
Draft
[WAL-1347] feat(mdoc): implement NFC proximity transport#2165szijpeter wants to merge 13 commits into
szijpeter wants to merge 13 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
August 30, 2026 22:09
a578bc7 to
340cce3
Compare
szijpeter
changed the base branch from
feature/wal-1346-proximity-wallet-demos
to
feature/wal-1346-reader-trust-policy
August 30, 2026 22:09
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
2 times, most recently
from
August 30, 2026 23:30
e4995e1 to
34f5587
Compare
szijpeter
force-pushed
the
feature/wal-1346-reader-trust-policy
branch
from
August 31, 2026 10:14
1a98938 to
d1d35e5
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
2 times, most recently
from
September 1, 2026 10:45
97224bb to
a8a7634
Compare
szijpeter
changed the base branch from
feature/wal-1346-reader-trust-policy
to
feature/wal-1346-proximity-wallet-demos
September 1, 2026 10:53
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
4 times, most recently
from
September 1, 2026 13:06
de2a097 to
bd58ed4
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 1, 2026 14:55
4752ed4 to
786edf1
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
2 times, most recently
from
September 1, 2026 15:57
86e45b2 to
7ea51f7
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 2, 2026 08:54
8858e02 to
60b3c88
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 2, 2026 08:54
7ea51f7 to
f837c81
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 2, 2026 09:43
60b3c88 to
8bd5718
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 2, 2026 09:43
f837c81 to
1cb6204
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 2, 2026 10:04
8bd5718 to
f828be5
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
2 times, most recently
from
September 2, 2026 10:28
9acafd4 to
370b687
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 2, 2026 12:00
370b687 to
aa15be8
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 2, 2026 14:59
279e391 to
02d41ca
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 2, 2026 14:59
d3a3ba1 to
d43e58a
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 2, 2026 19:37
02d41ca to
1442b3d
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 2, 2026 19:37
d43e58a to
5639e50
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 3, 2026 14:12
1442b3d to
5b2e130
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 3, 2026 14:12
5639e50 to
384ff4b
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 4, 2026 12:04
5b2e130 to
de6101a
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 4, 2026 12:04
4b1b1e6 to
c95de2e
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 4, 2026 12:51
de6101a to
e3ec547
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 4, 2026 12:51
c95de2e to
da3e671
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 4, 2026 13:11
e3ec547 to
7731703
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 4, 2026 13:12
da3e671 to
c617c96
Compare
szijpeter
force-pushed
the
feature/wal-1346-proximity-wallet-demos
branch
from
September 4, 2026 14:38
7731703 to
6407f3e
Compare
szijpeter
force-pushed
the
feature/wal-1347-nfc-proximity-transport
branch
from
September 4, 2026 14:38
c617c96 to
d8375dc
Compare
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements holder-side NFC engagement and device retrieval for WAL-1347, so the existing proximity session can use conventional ISO NFC handover/retrieval and an isolated provisional NFC Engagement v2 profile through the same wallet contract.
This PR is stacked on the complete WAL-1346 wallet integration and application-configurable reader-trust policy in walt-id/waltid-identity#2160. The implementation follows the architecture contract in walt-id/waltid-architecture#60. The stacked demo-host integration is in walt-id/waltid-identity#2166.
What Changed
Shared mdoc and transport protocol
Platform integration
CardSessionbridge for native and Compose hosts. Public Core NFC support and eligibility remain runtime-gated. Presentment-intent assertion acquisition is best-effort and does not block an eligibleCardSession; the assertion is released on every finish path.Wallet SDK
Architecture Notes
handoverSessionEstablishmentcapability remains unadvertised until the unresolved DIS placeholder can be reconciled with authoritative material.seqvalues. Structurally valid inbound values are non-enforcing in this provisional profile; malformed values and anyseqon conventional sessions fail closed.Caveats and Follow-Ups
ae4efeb2dfaf60fa7daaab80db4415c4a63c57b0; neither result is cross-credited to the rewritten head, so exact-head physical qualification remains open.mDL_Tech_DE_NFC_01through_17andmDL_Tech_DR_NFC_01through_07. They are mapped into the qualification plan in architecture PR #61; the normative TS main text is still required before any conformance claim.handoverSessionEstablishment. Bounded Android direct and NFCv2-to-BLE hybrid interoperability, early field-loss handling, fresh-session recovery, and a 42,507-byte single-APDU response remain exact-build evidence rather than standards qualification.Breaking