Split action_ext on the first dot to match the API - #94
Open
concentrator wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A path's final segment was split into
action_name/action_exton the last dot, but the API splits on the first dot. For a multi-dot segment (archive.tar.gz) the provider producedaction_ext = gz, disagreeing with the API'star.gz— which the hits data source catches as an action-hash mismatch and turns into a hard error.actionNameExtConditions(hits path-to-action) andparseLastSegment(action_pathexpansion) split on the first dot viastrings.Cut.validateActionPathrejects a malformedaction_pathwildcard (a*fused into a value, e.g.report.2024.*) at plan time with a clear error, instead of silently building a non-matching rule.action.md,rules-core.md,hits-to-rules.mdreconciled to the first-dot behavior./.envdotfile case (emptyaction_name+action_ext=env), confirmed against the live API; consolidated the action-examples fixture to a singlespec/file (the round-trip test now reads it directly, dropping a duplicate 343-example copy).Behavior change
An existing multi-dot
action_pathresource re-decomposes on its next plan (one-time re-plan). This is intended — it aligns the provider with the API's decomposition.Test plan
validateActionPathvalid/invalid table; round-trip test passes on the consolidated fixture.make testandmake lintgreen.disable_stampCRUD.