Repository navigation
Conversation
lwaldron
commented
Apr 10, 2026
lwaldron
commented
Member
- Updated DESCRIPTION (version bump, R >= 4.0.0, standard biocViews)
- Migrated legacy inst/CITATION to bibentry() format
- Move inst/NEWS into top-level NEWS.md
- Cleared out explicit regex export in NAMESPACE to pass BiocCheck
- Updated DESCRIPTION (version bump, R >= 4.0.0, standard biocViews) - Migrated legacy inst/CITATION to bibentry() format - Consolidated inst/NEWS into top-level NEWS.md - Cleared out explicit regex export in NAMESPACE to pass BiocCheck Co-authored-by: Gemini Code Assist <gemini@google.com>
- Removed hardcoded textVersion that suppressed default bibentry formatting - Added PMID 23550061 to the citation fields - Cleaned up obsolete abstract and eprint fields Co-authored-by: Gemini Code Assist <gemini@google.com>
There was a problem hiding this comment.
Pull request overview
Modernizes the curatedOvarianData package metadata/layout to better align with current Bioconductor package standards and checks.
Changes:
- Updated package metadata in
DESCRIPTION(version bump, R dependency, biocViews, Authors@R updates). - Replaced legacy
citEntry()CITATION format withbibentry()and consolidated NEWS into top-levelNEWS.md. - Removed the legacy
exportPattern()fromNAMESPACE(data-only package, no exports).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NEWS.md | Adds a new release entry and moves the previous “initial release” text into the consolidated NEWS file. |
| NAMESPACE | Removes exportPattern() and leaves an explicit “no exports” note for this data-only package. |
| inst/NEWS | Removed legacy inst-level NEWS content as part of consolidating release notes. |
| inst/CITATION | Migrates CITATION to bibentry() format and updates URL/metadata fields. |
| DESCRIPTION | Bumps version, adjusts R dependency, updates biocViews, and refines Authors@R entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| person("NCI", role = "fnd", | ||
| comment = c(GrantNo. = "U24CA289073")) | ||
| person("Levi", "Waldron", email = "lwaldron.research@gmail.com", role = c("aut", "cre"), comment = c(ORCID = "0000-0003-2725-0694")), | ||
| person("National Cancer Institute", role = "fnd", comment = "5U24CA180996") |
There was a problem hiding this comment.
In Authors@R, the funding entry changed comment from a named vector (e.g., c(GrantNo. = ...)) to an unnamed string. Using a named comment (e.g., comment = c(GrantNo. = "...")) keeps the metadata self-describing/consistent with the ORCID comment style and avoids losing the grant label in tooling that parses Authors@R.
Suggested change
| person("National Cancer Institute", role = "fnd", comment = "5U24CA180996") | |
| person("National Cancer Institute", role = "fnd", comment = c(GrantNo. = "5U24CA180996")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.