Repository navigation
Add the create-protocol skill and mark optional template items uniformly - #50
Merged
Merged
Conversation
…mplate Every optional item in the template is marked "Optional, delete if unneeded." so deleting the unused ones is a search. The skill copies the template, fills it from the current schema, asks the two citation questions separately, and validates before reporting. Closes #35.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
Two parts.
Template. Every optional item in
template/protocols/example-protocol/now carries the literal markerOptional, delete if unneeded.: each optional frontmatter field, the## Notessection, and the exampletests/directory. Deleting the unused ones becomes a search rather than a judgement. The existing ADR 0014 citation guidance stays. CONTRIBUTING.md describes the convention. The template still fails validation only on the placeholder citation, as the test expects.Skill.
skills/create-protocolcopies that template, reads the schema from the local checkout of the standard at run time rather than from an embedded copy, asks the two citation questions separately per ADR 0014, writes Materials with conditions per ADR 0017 and at least one Step, opens History with a first entry, walks every marker and either fills or deletes the item, strips the markers, runs the validator, and reports what was deleted and what is left open. It never invents authors, ORCIDs, dates, DOIs, or tool versions, andstatusstaysdraftper ADR 0013.Dogfood. Following the skill literally against waldronlab/agent-protocols#50 (Shannon diversity) produced a protocol that validates except for the placeholder citation, which is correctly left as an open call: the issue names no publication, and self-citing the collection DOI is a claim, not a default. The run surfaced several things the spec left implicit and they are in the skill now: a parameter may have no default and must say why, computation-time checks may live in Steps, and house style on empty lists wins over the template. The protocol itself is not in this PR, because waldronlab/agent-protocols#53 already proposes one for the same issue.
🤖 Drafted with Claude Code