Repository navigation
Conditions on materials: where they live and what a violation means (ADR 0017) - #47
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
…warning ADR 0017 (Proposed). Materials is the single home for conditions on inputs; must stops before Step 1, should warns and proceeds. Diagnostic outcomes may carry expected_warning; result.yaml may carry warnings. Runner and test-protocol skills check Materials before Step 1. Closes #46 Drafted with Claude Code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…no early return The with-tests fixture's Materials now states the orientation condition its test expects a warning for. Diagnostic mode is defined as failing a condition in Materials. Run-record example at 0.2.0. Malformed warnings is reported alongside the other failures rather than short-circuiting. expected_warning is stripped in the model. Blank-warning invalid fixture. Drafted with Claude Code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
lwaldron
force-pushed
the
materials-conditions
branch
from
October 23, 2026 14:00
8682b50 to
9f44eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46. ADR 0017 is Proposed, not Accepted; flip it on merge if you agree with it.
What changes:
PROTOCOL_STANDARD.md, Markdown Content Structure: Materials lists every input and every condition on it; steps don't add conditions; must stops before Step 1, should warns and proceeds. Scoped to protocol Materials text, not the standard's own prose. The skeleton gainsInput dataandParametersbullet groups showing the form.PROTOCOL_STANDARD.md, Tests: a diagnostic outcome may carryexpected_warning, a phrase matched case-insensitively against the executor'swarnings. It accompanies evidence, it isn't evidence.warnings(list of strings) is allowed inresult.yamlin either mode and is reserved alongsideoutcomeandobservation.scripts/models.py,scripts/check_test_result.py: the above, checker at 0.2.0. The shape shows thatwarningsexists and withholds the phrase.skills/protocol-runner2.1.0: step 6.1 checks Materials before Step 1; step 7 lists warnings with departures.skills/test-protocol0.2.0: same check;warningsinresult.yaml.template/: anInput databullet with one must and one should.docs/adr/0017-conditions-on-materials.mdand the index.orientation_correctedoutcome now expects a warning; two new pytest cases. 123 pass.Not changed: the validator's body checks. It can't read prose semantics; the rule is applied in review.
Drafted with Claude Code; decisions and edits are mine.