fix(workers): extend the /goal Stop-hook deadlock fix to orchestrator + tdd - #9
Merged
Merged
Conversation
…ator + tdd drivers PR #6 fixed runGoal, but the same bug threatens every prose-emitting autonomous worker: the user-facing no-vibes Stop hook blocks their FINISHED/EVIDENCE closeout, so they run to the turn cap and never terminate. Exposure audit of baseSdkOptions callers found two more: orchestrator.ts (packet worker — prose EVIDENCE/STATUS) and tdd.ts (prose FINAL TDD BLOCK), both loading settings-file hooks with no settingSources override — same class as runGoal. Structured-output workers (verify, mutation-verify, ssc) emit JSON, don't trip no-vibes, and are left unchanged. Fix: settingSources:[] on the orchestrator + tdd worker spawns (matching runGoal). Worker enforcement is the separate blind verify, not the tone hooks. typecheck + tests green (runtime 277). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #6. The no-vibes Stop hook blocking a prose worker's FINISHED closeout (→ max-turns) isn't unique to runGoal. Exposure audit: orchestrator.ts + tdd.ts are prose-emitting autonomous workers loading settings-file hooks with no override — same class. Fix: settingSources:[] on both (structured-output workers verify/mutation-verify/ssc are unaffected). typecheck + tests green.
🤖 Generated with Claude Code