Mirror upstream PR: Add sha256 support - #1
Closed
wagoodman wants to merge 13 commits into
Closed
Conversation
copies a few private methods from the stdlib x509 package.
Uses the x509util package to get a wider range of supported hash functions.
Go 1.10 is more strict about Asn.1 annotations. This removes the incorrect “explicit” annotation from encryptedContentInfo.EncryptedContent. I’m also using openssl to generate the fixture now so that we aren’t testing with our own output for `Decrypt()` Fixes fullsailor#31
Fix failure to parse enveloped data in Go 1.10
Fix signer digest algorithm
Previously the encrypt method was grouping together multiple algorithms and handling them the same. In the decryption code this somewhat makes sense because the crypto.Cipher will take care of figuring out which algorithm it needs to use. When encrypting though if AES-128-CBC is requested we were encrypting as AES-128-GCM which didn't make sense.
Add AES-128-CBC support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror upstream fullsailor#19 PR