implement the external code review, plus three defects it missed - #8

Merged

w453y merged 158 commits into

mainfrom

Sep 2, 2026

Commits on Aug 16, 2026

echo-tx: bind the raw socket to protocol 0, not ETH_P_ALL
w453y
committed
04bdfe4
build: take the BPF include path from the compiler triple
w453y
committed
2032fd4
engine, loader: locate bfd_xdp.o relative to the binary
w453y
committed
0bb8cbf
engine, loader: make the XDP attach mode selectable
w453y
committed
5d9ea4c
gitignore the review patch scripts
w453y
committed
be57101
fsm: notify bfdd after recording the peer's parameters, not before
w453y
committed
b418011
engine: validate --dp-hold and check every socket() return
w453y
committed
651ed53
loader: render v6 session keys and dump all nine stat slots
w453y
committed
184e5b8
loader: decide the CSV header from an explicit seek
w453y
committed
000e8ad
tests: fail on an --only name that matches no case
w453y
committed
88cd653
tests: cover the fragment drop and the unconfigured-pair GTSM
w453y
committed
803313c
xdp: apply the deferred GTSM before the promiscuous pass
w453y
committed
087c9af
xdp: drop fragmented UDP aimed at a BFD port
w453y
committed
3fa4ffc
tests: cover the A and M bit discard
w453y
committed
258edc7
xdp: discard control packets carrying the A or M bit
w453y
committed
eb4add9
tests: pin the phantom sessions by address
w453y
committed
bb170fc
loader: guard the age arithmetic against a racing RX
w453y
committed
aa693cd
share one control-packet acceptance rule between both planes
w453y
committed
a78a879
engine: enforce GTSM on the userspace receive path
w453y
committed
808ab96
engine: attach the XDP program through a bpf_link
w453y
committed
13819dd
engine: bound each receive drain per loop pass
w453y
committed
88a1eef
dplane: queue outbound messages instead of tearing down on EAGAIN
w453y
committed
ea67ef3
fsm: jitter the slow transmit rate too
w453y
committed
8845deb
xdp: give a failed sweeper arm a witness
w453y
committed
2e5edca
dplane: count received control packets in both planes
w453y
committed
650ab2b
engine: fix echo_peers and tx_config lifetime on shared peers and address moves
w453y
committed
343bb8f
fsm: announce AdminDown before freeing a session
w453y
committed
78547cd

Commits on Aug 17, 2026

docs: what the external review changed and why
w453y
committed
e89437c
gitignore: match every numbered patch script, not just 0x
w453y
committed
66b99ff
dplane: say when a session is not on the attached interface
w453y
committed
68902c2
define the stat slots once and name every count() site
w453y
committed
9e4b5a6
dplane: report the echo counters the engine already keeps
w453y
committed
b650227
engine: count flaps and dump a JSON snapshot on SIGUSR1
w453y
committed
ee9e0de
make the kernel sweep interval a load-time tunable
w453y
committed
762de40
fsm: record what each detection cost
w453y
committed
a81cfa6
measure what the sweep interval costs; it costs nothing
w453y
committed
ba1d338
tests: a namespace rig for the userspace receive path
w453y
committed
9b7f30e
engine: accept IPv6 in static mode
w453y
committed
d9ab9ef

Commits on Aug 24, 2026

engine: enforce GTSM by reading the hop count, not IP_MINTTL
w453y
committed
7815e87
engine: require your_disc to name a session, as XDP does
w453y
committed
4ff544d
docs: what the namespace rig covers and what it found
w453y
committed
68c0b8e
sweep_ladder: --stress arm to starve the userspace loop
w453y
committed
ca61f16
docs: starved detection, engine and wire agree on a ~950ms bound
w453y
committed
3a754fd
docs: keep the exploratory starvation capture the boundary example comes from
w453y
committed
56523f6
docs: point the starved-detection files list at the exploratory capture
w453y
committed
289756f
engine: --tick-us to vary the main loop tick without a rebuild
w453y
committed
ab46d1e
engine: count main loop passes and inter-pass gaps, warn on sub-jiffy ticks
w453y
committed
cd7a7e9
sweep_ladder: --knob to vary --tick-us instead of --sweep-us
w453y
committed
4f0854f
docs: tick ladder, the tick quantizes detection down to one jiffy and no further
w453y
committed
dbdea40
docs: tick ladder table column is gaps, not passes
w453y
committed
4d1beff
tests: pin the shared struct layouts in both compilers
w453y
committed
a825576
tests: pin the shared enum values too
w453y
committed
96979d6

Commits on Aug 25, 2026

Commits on Aug 26, 2026

tests: deferred GTSM cases and a prog_flags seam for xdp_run
w453y
committed
388e4c2
xdp: name the multihop flag by value, not by bit index
w453y
committed
8696ea2
tests: GTSM and deferred-gate cases for v6
w453y
committed
e871b68
tests: shared detect-basis vectors, engine driver
w453y
committed
ba79e48
build: rebuild the unit harnesses when their headers change
w453y
committed
d7fd923
tests: drive the detect vectors against the XDP copy of the rule
w453y
committed
c31a92f
engine: a test seam for the bffdp read path
w453y
committed
3f550b3
tests: libFuzzer target for the bffdp parser
w453y
committed
054120f
engine: bound the bffdp parse loop against a mid-loop drop
w453y
committed
0441f6c
docs: the dp_read out-of-bounds read and how it was found
w453y
committed
6f9d748

Commits on Aug 30, 2026

ci: build and run the testbed-free suites
w453y
committed
2dd9d20
ci: build and run the testbed-free suites
w453y
committed
3e2cf88
ci: a netns job for the Layer 3 scenarios
w453y
committed
46bfb82
tests: skip the engine-death cases when bpftool is absent
w453y
committed
8dafd30
tests: read attach state from ip -d, not bpftool
w453y
committed
9e72d34
ci: fuzz regressions in the gate, an open-ended run on a schedule
w453y
committed
60f61e1
tests: demonstrate that kernel-TX carries sessions through a stopped userspace
w453y
committed
c9e8cfd
docs: kernel-TX carries sessions through a stopped userspace
w453y
committed
48ff9bb
build: gate the userspace parity rig alongside the Layer 3 scenarios
w453y
committed
3212b23

Commits on Aug 31, 2026

Commits on Sep 1, 2026

Commits on Sep 2, 2026

ci: a self-hosted job that runs every suite including the map test
w453y
committed
50a3ade
ci: clean the self-hosted runner after a job, not only before
w453y
committed
4d35e68
ci: stop the sudo suites leaving root-owned files in the work tree
w453y
committed
b6f67b2
ci: one workflow, self-hosted full suite plus a hosted portability gate
w453y
committed
7de3346
ci: pin the LLVM floor as a matrix rather than a comment
w453y
committed
aa1c2e6
engine: check the receive fds in code, and gate on scan-build
w453y
committed
3dbc82d
ci: run the unit suites under a chosen kernel in a microVM
w453y
committed
1ed412a
ci: correct the note about vng exit propagation
w453y
committed
728748c
build: -Werror, and build userspace with both compilers in CI
w453y
committed
477cc07
perf: recompute the published benchmark numbers from the pcaps
w453y
committed
0309498
perf: read the pcaps with -n so the harness is host-independent
w453y
committed
b13216e
perf: say what tcpdump actually printed when nothing parses
w453y
committed
4ac9b5f
perf: parse the BFD state from the hex, not from tcpdump's decode
w453y
committed
7335d80
ci: build the BPF object for aarch64, and prove the include path matters
w453y
committed
7b2299d
ci: point arm64 at ports.ubuntu.com, not the amd64 mirror
w453y
committed
16cc030
ci: the cross job needs libbpf-dev for bpf_helpers.h
w453y
committed
d608f2e
tests: scenario 7, multihop over a router namespace with TTL restore
w453y
committed
9852361
docs: two RX-clocked engines saturate the link
w453y
committed
abf3e84
docs: correct the detection mechanism, and record what symmetric ktx measured
w453y
committed
06aa950
writeup: the detection mechanism I had wrong, and what the ladders showed
w453y
committed
2eed3b8
writeup: two RX-clocked ends flood rather than fall silent
w453y
committed
802aa99
docs: tests/README describes four layers, not three scripts
w453y
committed
a7e2583
docs: point at the X-macro rather than a slot count that rots
w453y
committed
2568503
tests: assert the v6 echo return path and the v6 reflect matrix
w453y
committed
30470f4
xdp: consume our own IPv6 echo on return
w453y
committed
6c2587d
engine: originate IPv6 echo
w453y
committed
9452f47
tests: read the peer as w453y so dp_hold keeps its oracle under sudo
w453y
committed
875bc56
tests: prove IPv6 echo origination on the wire
w453y
committed
fd145c1
docs: record IPv6 echo origination and the assumption it corrected
w453y
committed
a70c6b2