Skip to content

fix(chart): label the Services so the VMServiceScrape can select them #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Balevka merged 1 commit into from
Aug 7, 2026
Merged

fix(chart): label the Services so the VMServiceScrape can select them #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/agent-rpc-mcp/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v2
name: agent-rpc-mcp
description: Deploys the Agent RPC MCP data plane and management plane as separate pods.
type: application
version: 0.1.0
version: 0.1.1
6 changes: 6 additions & 0 deletions charts/agent-rpc-mcp/templates/service-data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ kind: Service
metadata:
name: agent-rpc-mcp
namespace: {{ .Values.namespace }}
# The VMServiceScrape selects SERVICES by their own metadata labels.
# Without this block the scrape matches nothing and the plane goes dark
# while the pod stays Healthy, which is exactly what happened on
# 2026-08-07: `up{namespace="agent-rpc-mcp"}` returned no series at all.
labels:
{{- include "agent-rpc-mcp.data.labels" . | nindent 4 }}
spec:
selector:
{{- include "agent-rpc-mcp.data.labels" . | nindent 4 }}
Expand Down
6 changes: 6 additions & 0 deletions charts/agent-rpc-mcp/templates/service-mgmt.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ kind: Service
metadata:
name: agent-rpc-mgmt-mcp
namespace: {{ .Values.namespace }}
# The VMServiceScrape selects SERVICES by their own metadata labels.
# Without this block the scrape matches nothing and the plane goes dark
# while the pod stays Healthy, which is exactly what happened on
# 2026-08-07: `up{namespace="agent-rpc-mcp"}` returned no series at all.
labels:
{{- include "agent-rpc-mcp.mgmt.labels" . | nindent 4 }}
spec:
selector:
{{- include "agent-rpc-mcp.mgmt.labels" . | nindent 4 }}
Expand Down
Loading