Modify header extension init to ignore "stopping" transceivers - #250
Merged
Conversation
jan-ivar
approved these changes
Jan 15, 2026
Contributor
Author
|
Asking @dontcallmedom for help with getting the linkage right. |
dontcallmedom
added a commit
to w3c/webrtc-pc
that referenced
this pull request
Jan 15, 2026
Member
|
filed w3c/webrtc-pc#3087 for this |
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
Jun 1, 2026
This CL adds a Web Platform Test to verify that addTransceiver ignores transceivers where the [[Stopping]] internal slot is true when copying header extensions from existing transceivers of the same kind, matching the spec change in w3c/webrtc-extensions#250. Bug: webrtc:439514253 Change-Id: Ib66cfbf43de8a3b6e6bc861587128fd8bb64f015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7880596 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1639632}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 1, 2026
This CL adds a Web Platform Test to verify that addTransceiver ignores transceivers where the [[Stopping]] internal slot is true when copying header extensions from existing transceivers of the same kind, matching the spec change in w3c/webrtc-extensions#250. Bug: webrtc:439514253 Change-Id: Ib66cfbf43de8a3b6e6bc861587128fd8bb64f015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7880596 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1639632}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 1, 2026
This CL adds a Web Platform Test to verify that addTransceiver ignores transceivers where the [[Stopping]] internal slot is true when copying header extensions from existing transceivers of the same kind, matching the spec change in w3c/webrtc-extensions#250. Bug: webrtc:439514253 Change-Id: Ib66cfbf43de8a3b6e6bc861587128fd8bb64f015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7880596 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1639632}
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jun 4, 2026
…ansceivers in addTransceiver, a=testonly Automatic update from web-platform-tests WebRTC: Add WPT for ignoring stopping transceivers in addTransceiver This CL adds a Web Platform Test to verify that addTransceiver ignores transceivers where the [[Stopping]] internal slot is true when copying header extensions from existing transceivers of the same kind, matching the spec change in w3c/webrtc-extensions#250. Bug: webrtc:439514253 Change-Id: Ib66cfbf43de8a3b6e6bc861587128fd8bb64f015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7880596 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1639632} -- wpt-commits: ceca7596e4a5652236bfd018ed04220e9a1c0bdf wpt-pr: 60327
youennf
approved these changes
Jun 11, 2026
Contributor
Author
|
These two test changes should make it: web-platform-tests/wpt@78411c0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249
Preview | Diff