Update merge queue configuration#13
Conversation
Signed-off-by: Oleksandr B. <null>
📝 WalkthroughWalkthroughThis PR modifies .mergify.yml, changing the label-removal action for the "Delete the merge-when-green label after merge" rule to explicit list syntax, and adds merge queue configuration via queue_rules and merge_queue.max_parallel_checks settings. ChangesMergify Configuration Update
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.mergify.yml:
- Around line 19-21: The merge queue setting is unused because there are no
queue rules and the existing PR rule still merges directly. Update the Mergify
config by either adding a proper queue rule and switching the relevant rule to
use the queue action if merge-queue behavior is intended, or remove the
merge_queue.max_parallel_checks and queue_rules entries entirely. Check the
existing Mergify rule definitions around merge: and queue_rules to keep the
configuration consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| queue_rules: [] | ||
| merge_queue: | ||
| max_parallel_checks: 2 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the target file with line numbers.
if [ -f .mergify.yml ]; then
echo "== .mergify.yml =="
cat -n .mergify.yml
else
echo ".mergify.yml not found"
fi
# Find any queue-related Mergify config elsewhere.
echo
echo "== queue-related matches =="
rg -n --hidden --glob '.mergify.yml' --glob '.mergify.yaml' --glob '.github/**' 'queue_rules|merge_queue|actions:\s*$|queue:' .
# Show a compact file list for Mergify-related configs.
echo
echo "== mergify-related files =="
git ls-files | rg '(^|/)\.mergify\.ya?ml$|mergify'Repository: w0rxbend/system-bootstrap
Length of output: 997
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# If .mergify.yml is present, inspect surrounding context for the rule using merge vs queue.
python3 - <<'PY'
from pathlib import Path
p = Path('.mergify.yml')
if not p.exists():
print("missing")
raise SystemExit(0)
lines = p.read_text().splitlines()
for i, line in enumerate(lines, start=1):
if 1 <= i <= len(lines):
if 1 <= i <= len(lines):
pass
for start in [1]:
end = min(len(lines), 120)
for i in range(start, end + 1):
print(f"{i:4d}: {lines[i-1]}")
PYRepository: w0rxbend/system-bootstrap
Length of output: 760
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Read Mergify docs references present in the repo, if any.
rg -n --hidden 'max_parallel_checks|queue_rules|merge_queue|queue action|merge queue' .Repository: w0rxbend/system-bootstrap
Length of output: 271
merge_queue.max_parallel_checks is dead config here .mergify.yml:19-21 defines no queue rules, and the PR rule still uses merge: directly. Add a queue rule plus queue action if merge-queue behavior is intended; otherwise drop these lines.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.mergify.yml around lines 19 - 21, The merge queue setting is unused because
there are no queue rules and the existing PR rule still merges directly. Update
the Mergify config by either adding a proper queue rule and switching the
relevant rule to use the queue action if merge-queue behavior is intended, or
remove the merge_queue.max_parallel_checks and queue_rules entries entirely.
Check the existing Mergify rule definitions around merge: and queue_rules to
keep the configuration consistent.
Summary by CodeRabbit